Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin setuptools build dependency #8961

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Unpin setuptools build dependency #8961

merged 1 commit into from
Aug 17, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 17, 2023

Type of Changes

Type

Description

This allows building with newer versions of setuptools. We also can remove explicitly requiring wheel, because setuptools will ask for it for us when a wheel is built. Per setuptools documentation:

Historically this documentation has unnecessarily listed wheel in the requires list, and many projects still do that. This is not recommended. The backend automatically adds wheel dependency when it is required, and listing it explicitly causes it to be unnecessarily required for source distribution builds. You should only include wheel in requires if you need to explicitly access it during build time (e.g. if your project needs a setup.py script that imports wheel).

My motivation is in building this package for nixpkgs using build, which validates build dependency versions, and we are using newer versions of setuptools and wheel in nixpkgs.

This allows building with newer versions of setuptools. We also can
remove explicitly requiring wheel, because setuptools will ask for it
for us when a wheel is built.
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #8961 (a0ac282) into main (456bf76) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8961   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files         173      173           
  Lines       18592    18592           
=======================================
  Hits        17802    17802           
  Misses        790      790           

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Aug 17, 2023
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening a MR. I uuess the idea was to not have setuptools suddenly fail because of a new version being released but if it can help those that also want to package pylint let's change this.

@Pierre-Sassoulas Pierre-Sassoulas merged commit fd80514 into pylint-dev:main Aug 17, 2023
27 of 28 checks passed
@tjni tjni deleted the unpin-build-dependencies branch August 17, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants