Take the FORCE_COLOR and NO_COLOR environment variables into account
#9128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stavros Ntentos <[email protected]>
Use the `_is_env_set_and_non_empty`, and the logic decided in the issue, to modify the reporter(s) list accordingly. At most, one reporter should be modified - the one going to `stdout`. Hooking before the `self.set_reporter` was deemed as the smallest incision. For no particular reason, it was decided that `_handle_force_color_no_color` would modify its input; so there would be no need for re-assigning the input we want to modify anyway. Signed-off-by: Stavros Ntentos <[email protected]>
Signed-off-by: Stavros Ntentos <[email protected]>
Signed-off-by: Stavros Ntentos <[email protected]>
This comment has been minimized.
This comment has been minimized.
|
Any ideas of how to detect that a reporter is attached to |
jacobtylerwalls
changed the title
FORCE_COLOR and NO_COLOR environnement variables into accountFORCE_COLOR and NO_COLOR environement variables into account
jacobtylerwalls
changed the title
FORCE_COLOR and NO_COLOR environement variables into accountFORCE_COLOR and NO_COLOR environment variables into account
This comment has been minimized.
This comment has been minimized.
|
÷1 to I suggest to leave https://docs.pytest.org/en/stable/reference/reference.html#envvar-PY_COLORS |
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 51950fe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for
NO_COLORandFORCE_COLOR(andPY_COLORS, as an alias toFORCE_COLOR)environment variables has been added. When running
pylint, the reporter that reportsto
stdoutwill be modified according to the requested mode.The order is:
NO_COLORFORCE_COLOR,PY_COLORS--output=....Signed-off-by: Stavros Ntentos [email protected]
skip-newsif the change does not need to be in the changelog.towncrier create <IssueNumber>.<type>which will beincluded in the changelog.
<type>can be one of the types defined in./towncrier.toml.If necessary you can write details or offer examples on how the new change is supposed to work.
tox -e docsDon't hesitate to open multiple PRs if the change requires it. If your review is so
big it requires to actually plan and allocate time to review, it's more likely
that it's going to go stale.
and preferred name in
script/.contributors_aliases.jsonType of Changes
Description
Fixes #3995