Optionally disable consider-using-join for non-empty separator #9129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
requested changes
Oct 8, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9129 +/- ##
=======================================
Coverage 95.76% 95.76%
=======================================
Files 173 173
Lines 18676 18680 +4
=======================================
+ Hits 17885 17889 +4
Misses 791 791
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Only suggest joining with separators when a new option 'suggest-join-with-non-empty-separator' is specified.
Co-authored-by: Pierre Sassoulas <[email protected]>
Co-authored-by: Pierre Sassoulas <[email protected]>
theirix
force-pushed
the
consider-using-join-non-empty
branch
from
1cabef4
to
f9ff7d7
Compare
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit f9ff7d7 |
Pierre-Sassoulas
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Skip
consider-using-joincheck for non-empty separators unless asuggest-join-with-non-empty-separatoroption is set toyes.Closes #8701