Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wrong-exception-operation] Fix FP for tuple concatenation of exception types #9289

Merged
merged 1 commit into from
Dec 10, 2023
Merged

[wrong-exception-operation] Fix FP for tuple concatenation of exception types #9289

merged 1 commit into from
Dec 10, 2023

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #9288

@jacobtylerwalls jacobtylerwalls added False Positive 🦟 A message is emitted but nothing is wrong with the code backport maintenance/3.3.x labels Dec 10, 2023
@jacobtylerwalls jacobtylerwalls added this to the 3.0.3 milestone Dec 10, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Merging #9289 (0b7cda1) into main (796eae3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9289   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files         173      173           
  Lines       18762    18767    +5     
=======================================
+ Hits        17976    17981    +5     
  Misses        786      786
Files Coverage Δ
pylint/checkers/exceptions.py 98.30% <100.00%> (+0.03%) ⬆️

@github-actions GitHub Actions
Copy link
Contributor

🤖 Effect of this PR on checked open source code: 🤖

Effect on home-assistant:
The following messages are no longer emitted:

  1. wrong-exception-operation:
    Invalid exception operation. Did you mean '(JSON_DECODE_EXCEPTIONS, (vol.MultipleInvalid, ))' instead?
    https://github.com/home-assistant/core/blob/88ddc2512972423f36447c555ba568fd6e90ed73/homeassistant/components/mqtt/config_flow.py#L568

This comment was generated for commit 0b7cda1

@jacobtylerwalls jacobtylerwalls merged commit 8d4c6c1 into pylint-dev:main Dec 10, 2023
46 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 10, 2023
@jacobtylerwalls @github-actions
[wrong-exception-operation] Fix FP for tuple concatenation of excepti…
6884b2e 
…on types (#9289)

(cherry picked from commit 8d4c6c1)
@github-actions github-actions bot mentioned this pull request Dec 10, 2023
Merged
jacobtylerwalls added a commit that referenced this pull request Dec 10, 2023
@github-actions @jacobtylerwalls
[wrong-exception-operation] Fix FP for tuple concatenation of excepti…
fea5483 
…on types (#9289) (#9291)

(cherry picked from commit 8d4c6c1)

Co-authored-by: Jacob Walls <[email protected]>
@jacobtylerwalls jacobtylerwalls deleted the 9288-exception-concat branch December 12, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Backported False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
3.0.3
Development

Successfully merging this pull request may close these issues.

wrong-exception-operation raised when concat tuple in except
3 participants
@jacobtylerwalls @DanielNoord @Pierre-Sassoulas