Disallow isort 5.13.0 #9290
Merged
Disallow isort 5.13.0 #9290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9290 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 173 173
Lines 18762 18762
=======================================
Hits 17976 17976
Misses 786 786 |
jacobtylerwalls
added
the
Skip news 🔇
|
For instance, in astroid, |
DanielNoord
reviewed
Dec 10, 2023
|
Well, one of the tests indicates runtime behavior changes in astroid, which is critical to pylint. So no, I don't think it's a matter of tests only. |
|
It's possible that 'yarg' is patching sys.path, which makes me nervous. |
DanielNoord
approved these changes
Dec 10, 2023
Pierre-Sassoulas
approved these changes
Dec 10, 2023
There was a problem hiding this comment.
LGTM.
Long term for this part of the code I thought about:
- use ruff instead of isort internally ?
- an optional dependency for isort/ruff like the one we have for spelling,
- dump the check and tell user to use isort/ruff directly ?
But of course fixing astroid is an option 😄
baby steps! 👶 🩰 |
jacobtylerwalls
added a commit
that referenced
this pull request
Dec 10, 2023
Refs #9270 (cherry picked from commit 47410ad) Co-authored-by: Jacob Walls <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #9270
isort5.13.0 pulls in many dev dependencies as runtime dependencies, some of which cause behavior differences in astroid. See logs.Refs PyCQA/isort#2206