Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[used-before-assignment] Fix FP under finally block #9452

Merged
merged 1 commit into from
Feb 22, 2024
Merged

[used-before-assignment] Fix FP under finally block #9452

merged 1 commit into from
Feb 22, 2024

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Feb 22, 2024 •
edited
Loading

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes #9451

@jacobtylerwalls jacobtylerwalls added False Positive 🦟 A message is emitted but nothing is wrong with the code C: used-before-assignment Issues related to 'used-before-assignment' check backport maintenance/3.3.x labels Feb 22, 2024
@jacobtylerwalls jacobtylerwalls added this to the 3.0.4 milestone Feb 22, 2024
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

@codecov Codecov
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (6d3e6a9) 95.81% compared to head (4392135) 95.81%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9452   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files         173      173           
  Lines       18788    18790    +2     
=======================================
+ Hits        18001    18003    +2     
  Misses        787      787
Files Coverage Ξ”
pylint/checkers/variables.py 97.26% <100.00%> (+<0.01%) ⬆️

@github-actions GitHub Actions
Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 4392135

@jacobtylerwalls jacobtylerwalls merged commit a83e6b9 into main Feb 22, 2024
50 checks passed
@jacobtylerwalls jacobtylerwalls deleted the uba-9451 branch February 22, 2024 13:57
github-actions bot pushed a commit that referenced this pull request Feb 22, 2024
@jacobtylerwalls @github-actions
[used-before-assignment] Fix FP under finally block (#9452)
6dbedeb 
Closes #9451

(cherry picked from commit a83e6b9)
@github-actions github-actions bot mentioned this pull request Feb 22, 2024
Merged
jacobtylerwalls added a commit that referenced this pull request Feb 22, 2024
@github-actions @jacobtylerwalls
[used-before-assignment] Fix FP under finally block (#9452) (#9453)
4d162c3 
Closes #9451

(cherry picked from commit a83e6b9)

Co-authored-by: Jacob Walls <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Backported C: used-before-assignment Issues related to 'used-before-assignment' check False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
3.0.4
Development

Successfully merging this pull request may close these issues.

used-before-assignment FP in finally
2 participants
@jacobtylerwalls @Pierre-Sassoulas