Fix FP for possibly-used-before-assignment with assert_never()
#9645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
False Positive π¦
Pierre-Sassoulas
approved these changes
May 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9645 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 174 174
Lines 18896 18900 +4
=======================================
+ Hits 18110 18114 +4
Misses 786 786
|
|
π€ Effect of this PR on checked open source code: π€ Effect on pytest:
This comment was generated for commit 8b1aab1 |
Pierre-Sassoulas
added a commit
that referenced
this pull request
May 18, 2024
β¦9645) (#9647) (cherry picked from commit 117be95) Co-authored-by: Jacob Walls <[email protected]> Co-authored-by: Pierre Sassoulas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #9643
Thanks @efroemling for the report and test case.