Fix a false positive for redefined-outer-name
#9678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦e defined in an exception-handling block which shares the same name as a local variable that has been defined in a function body. Closes pylint-dev#9671
mbyrnepr2
added
the
False Positive π¦
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9678 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 174 174
Lines 18813 18816 +3
=======================================
+ Hits 18027 18030 +3
Misses 786 786
|
do not emit ``redefined-outer-name`` if that is the case.
This comment has been minimized.
This comment has been minimized.
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 84f189c |
Pierre-Sassoulas
approved these changes
Jun 4, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
When there is a name defined in an exception-handling block which shares the same name as a local variable that has been defined in a function body. Check if the outer node is in the scope of an exception assignment and do not emit ``redefined-outer-name`` if that is the case. Closes #9671 (cherry picked from commit 57ae027)
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jun 4, 2024
When there is a name defined in an exception-handling block which shares the same name as a local variable that has been defined in a function body. Check if the outer node is in the scope of an exception assignment and do not emit ``redefined-outer-name`` if that is the case. Closes #9671 (cherry picked from commit 57ae027) Co-authored-by: Mark Byrne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix a false positive for
redefined-outer-namewhen there is a name defined in an exception-handling block which shares the same name as a local variable that has been defined in a function body.Closes #9671