Gracefully handle invalid paths csv regex in conf/args #9712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix 'ignore-paths', in particular, but others using this function too. Closes pylint-dev#9680
Pierre-Sassoulas
added
Crash 💥
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9712 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 174 174
Lines 18865 18865
=======================================
Hits 18082 18082
Misses 783 783
|
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit e852a9a |
Pierre-Sassoulas
commented
Jun 8, 2024
| @@ -82,12 +82,24 @@ def test_functional_config_loading( | |||
| expected_loaded_configuration = get_expected_configuration( | |||
| configuration_path, default_configuration | |||
| ) | |||
| runner = None # The runner can fail to init if conf is bad enough. | |||
There was a problem hiding this comment.
Suggested change
| runner = None # The runner can fail to init if conf is bad enough. |
This became useless afterward, I'll remove and rebase later.
mbyrnepr2
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix 'ignore-paths' from #9680, in particular, but other using this function too.
Closes #9680