Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setuptools to >=71.0.4 #9812

Merged
merged 4 commits into from
Jul 20, 2024
Merged

Update setuptools to >=71.0.4 #9812

merged 4 commits into from
Jul 20, 2024

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Jul 18, 2024 •
edited
Loading

@cdce8p cdce8p added Skip news 🔇 This change does not require a changelog entry backport maintenance/3.3.x labels Jul 18, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (6236b91) to head (135f165).
Report is 123 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9812   +/-   ##
=======================================
  Coverage   95.79%   95.79%           
=======================================
  Files         174      174           
  Lines       18902    18912   +10     
=======================================
+ Hits        18107    18117   +10     
  Misses        795      795

see 1 file with indirect coverage changes

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
jacobtylerwalls
jacobtylerwalls reviewed Jul 18, 2024
View reviewed changes
requirements_test_min.txt
@@ -9,4 +9,4 @@ pytest-timeout~=2.3
towncrier~=23.11
requests
# Voluntary for test purpose, not actually used in prod, see #8904
setuptools==41.6.0
setuptools;python_version>='3.12'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of removing the version pin, but can I ask why limit the python version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until 3.12, setuptools was bundled with Python itself.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the test dependencie set to this specific version as a regression test (see comment above) I think the threat reported is not applicable in this case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, I must manually uninstalled it to reproduce that issue 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the test dependencie set to this specific version as a regression test (see comment above) I think the threat reported is not applicable in this case.

I think so too. It nevertheless is a good idea to install a more modern version of setuptools and not keep the old one around. Especially as everyone has moved on since.

Pierre-Sassoulas
Pierre-Sassoulas reviewed Jul 18, 2024
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Marc I did not realize that the pyproject.toml needed an upgrade (I only saw the test dependencie where it's not applicable imo).

@jacobtylerwalls jacobtylerwalls added this to the 3.2.6 milestone Jul 18, 2024
@cdce8p cdce8p changed the title Update setuptools to >=71.0.1 Update setuptools to >=71.0.4 Jul 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 Effect of this PR on checked open source code: 🤖

Effect on pytest:
The following messages are no longer emitted:

  1. redefined-variable-type:
    Redefinition of importhook type from type to _pytest.assertion.DummyRewriteHook
    https://github.com/pytest-dev/pytest/blob/a7d5a8eba9addd119432fa71880b51052a89812f/src/_pytest/assertion/__init__.py#L80

This comment was generated for commit 135f165

@cdce8p cdce8p merged commit 60bd230 into pylint-dev:main Jul 20, 2024
38 checks passed
@cdce8p cdce8p deleted the fix-setuptools branch July 20, 2024 15:35
github-actions bot pushed a commit that referenced this pull request Jul 20, 2024
@cdce8p @github-actions
Update setuptools to >=71.0.4 (#9812)
8f23e39 
(cherry picked from commit 60bd230)
@github-actions github-actions bot mentioned this pull request Jul 20, 2024
Merged
jacobtylerwalls pushed a commit that referenced this pull request Jul 20, 2024
@cdce8p @jacobtylerwalls
Update setuptools to >=71.0.4 (#9812)
dfff77d 
(cherry picked from commit 60bd230)
cdce8p added a commit that referenced this pull request Jul 20, 2024
@github-actions @cdce8p
Update setuptools to >=71.0.4 (#9812) (#9824)
810c59c 
(cherry picked from commit 60bd230)

Co-authored-by: Marc Mueller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas left review comments

@jacobtylerwalls jacobtylerwalls jacobtylerwalls approved these changes

Assignees
No one assigned
Labels
backport maintenance/3.3.x Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Milestone
3.2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@cdce8p @Pierre-Sassoulas @jacobtylerwalls