Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a false positive unreachable for NoReturn coroutine functions #9844

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Fix a false positive unreachable for NoReturn coroutine functions #9844

merged 2 commits into from
Jul 31, 2024

Conversation

tomasz-michalski
Copy link
Contributor

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Fixed a false positive unreachable for NoReturn coroutine functions.

Closes #9840

@jacobtylerwalls jacobtylerwalls added False Positive 🦟 A message is emitted but nothing is wrong with the code backport maintenance/3.3.x labels Jul 30, 2024
@jacobtylerwalls jacobtylerwalls added this to the 3.2.7 milestone Jul 30, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 95.79%. Comparing base (c25bef3) to head (a234e50).
Report is 106 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9844   +/-   ##
=======================================
  Coverage   95.79%   95.79%           
=======================================
  Files         174      174           
  Lines       18925    18925           
=======================================
  Hits        18130    18130           
  Misses        795      795
Files with missing lines Coverage Ξ”
pylint/checkers/utils.py 95.73% <100.00%> (ΓΈ)

jacobtylerwalls
jacobtylerwalls reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pylint/checkers/utils.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
jacobtylerwalls
jacobtylerwalls approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Welcome aboard β›΅ !

@jacobtylerwalls jacobtylerwalls merged commit 83ade13 into pylint-dev:main Jul 31, 2024
40 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 31, 2024
@tomasz-michalski @github-actions
Fix a false positive unreachable for NoReturn coroutine functions (…
f36e571 
…#9844)

(cherry picked from commit 83ade13)
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit a234e50

jacobtylerwalls pushed a commit that referenced this pull request Jul 31, 2024
@github-actions @tomasz-michalski
Fix a false positive unreachable for NoReturn coroutine functions (…
7d1626c 
…#9844) (#9845)

(cherry picked from commit 83ade13)

Co-authored-by: Tomasz Michalski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtylerwalls jacobtylerwalls jacobtylerwalls approved these changes

Assignees
No one assigned
Labels
backport maintenance/3.3.x False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
3.2.7
Development

Successfully merging this pull request may close these issues.

False positive unreachable for NoReturn coroutine functions
2 participants
@tomasz-michalski @jacobtylerwalls