-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to maintain order of package paths #9887
Conversation
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9887 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 174 174
Lines 18944 18944
=======================================
Hits 18149 18149
Misses 795 795
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening the PR and thank you for the analysis. Can you add a fragment describing the fix in https://github.com/pylint-dev/pylint/tree/main/doc/whatsnew/fragments, please ?
Also I suppose you used dict.fromkeys for performance reasons compared to sorted or something else ?
|
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 8901361 |
(cherry picked from commit 8314743)
(cherry picked from commit 8314743) Co-authored-by: Akhil Kamat <[email protected]>
Type of Changes
Description
Refs #9883
Addresses the indeterminacy identified in #9883