Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to maintain order of package paths #9887

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Conversation

akamat10
Copy link
Contributor

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Refs #9883

Addresses the indeterminacy identified in #9883

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 95.80%. Comparing base (6bb335f) to head (8901361).
Report is 99 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9887   +/-   ##
=======================================
  Coverage   95.80%   95.80%           
=======================================
  Files         174      174           
  Lines       18944    18944           
=======================================
  Hits        18149    18149           
  Misses        795      795           
Files with missing lines Coverage Ξ”
pylint/lint/pylinter.py 96.65% <ΓΈ> (ΓΈ)

This comment has been minimized.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening the PR and thank you for the analysis. Can you add a fragment describing the fix in https://github.com/pylint-dev/pylint/tree/main/doc/whatsnew/fragments, please ?

Also I suppose you used dict.fromkeys for performance reasons compared to sorted or something else ?

@akamat10
Copy link
Contributor Author

Thank you for opening the PR and thank you for the analysis. Can you add a fragment describing the fix in https://github.com/pylint-dev/pylint/tree/main/doc/whatsnew/fragments, please ?
Will do.
Also I suppose you used dict.fromkeys for performance reasons compared to sorted or something else ?
The intent was to avoid duplication of paths as the previous code did and also have a deterministic order. After this change, whether or not we see the error I mentioned in the issue will depend on the order of file and modules specified in the command line.

This comment has been minimized.

Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 8901361

@Pierre-Sassoulas Pierre-Sassoulas merged commit 8314743 into pylint-dev:main Aug 27, 2024
44 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
Pierre-Sassoulas pushed a commit that referenced this pull request Aug 30, 2024
(cherry picked from commit 8314743)

Co-authored-by: Akhil Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants