Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin theano #2777

Merged
merged 10 commits into from
Jan 11, 2018
Merged

Unpin theano #2777

merged 10 commits into from
Jan 11, 2018

Conversation

ColCarroll
Copy link
Member

Another try to unpin theano, since it appears nothing is building, maybe enough restarts will help this one.

@ColCarroll ColCarroll mentioned this pull request Jan 8, 2018
@junpenglao
Copy link
Member

E       raise RuntimeError('To use MKL 2018 with Theano you MUST set "MKL_THREADING_LAYER=GNU" in your environement.')

@twiecki
Copy link
Member

twiecki commented Jan 9, 2018

We probably shouldn't be blocked by travis. If tests pass locally I think we should merge.

@junpenglao junpenglao mentioned this pull request Jan 9, 2018
4 tasks
@junpenglao
Copy link
Member

junpenglao commented Jan 11, 2018

(From @ColCarroll)
i cannot recreate the failures locally — if anyone is running linux and can, that would be interesting!
python -m pytest -vsx pymc3/tests/test_sgfs.py::test_minibatch
python -m pytest -vsx pymc3/tests/test_text_backend.py::TestTextSampling::test_supports_sampler_stats

I found out what the problem is: both test fail if setting njobs=1, which is the default for some reason in Travis.
Still trying to find out why test fail when njobs=1 tho, my guess is something to do with the random_seed

test setting `njobs=2`
@ColCarroll
Copy link
Member Author

Wow, thanks for fixing!

I think this is good enough for now – one is still marked experimental, one is not super well maintained. Seems like two reasonable goals for the next release might be making sgfs non-experimental, and deprecating all backends except h5py.

Will let someone else merge, or object!

@junpenglao junpenglao merged commit cad61ac into pymc-devs:master Jan 11, 2018
@nouiz
Copy link
Contributor

nouiz commented Jan 16, 2018

We think we fixed the problem, but as we where not able to reproduce it, can you test with the master of Theano to confirm if the batch_gemm compilation problem is fixed?

jordan-melendez pushed a commit to jordan-melendez/pymc3 that referenced this pull request Feb 6, 2018
* Unpin theano

* test setup

* setting MKL_THREADING_LAYER=GNU

* Don't use mkl-service

* Add nose

* Add back mkl-service, for reasons

* Try setting threading layer

* Use export instead of set

* Add pylint to requirements-dev

* intermedia fix

test setting `njobs=2`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants