fix PyMC3 variable is not replaced if provided in more_replacements (VI) #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrine
changed the title
|
Need to add to release note also for bugfix |
junpenglao
reviewed
Mar 8, 2018
| @@ -835,6 +835,20 @@ def test_sample_replacements(binomial_model_inference): | |||
| assert sampled.shape[0] == 101 | |||
|
|
|||
|
|
|||
| def test_var_replacement(): | |||
| X_mean = np.linspace(0, 10, 10, dtype='float32') | |||
There was a problem hiding this comment.
This is still causing test fail. Why not use dtype=theano.config.floatX?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2890