allow pymc3.Data() to support both int and float input data

[hottwaj]

Previously all input data was coerced to float when passed to pymc3.Data()

Attached changes implement this behaviour:

1. use dtype of passed array, if it has a dtype attr
2. otherwise test if input data is instance of int
3. otherwise assume float

WIP for #3813

[codecov]

Codecov Report

Merging #3816 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3816      +/-   ##
==========================================
- Coverage   90.78%   90.76%   -0.02%     
==========================================
  Files         133      133              
  Lines       20560    20570      +10     
==========================================
+ Hits        18665    18671       +6     
- Misses       1895     1899       +4     

[AlexAndorra]

Thanks @hottwaj -- looks like a great start!
Just a thought a first glance: I tend to think that np.int8 and np.int16 should be accepted (or at least cast to np.int32). Otherwise, in the current implementation these will raise a ValueError('Unsupported type'), while in fact they are types we want to support. Makes sense?
And I'm sure @rpgoldman will have valuable feedback!

[rpgoldman]

We should add tests to tests/test_data_container.py and not just check that the data creation works properly, but also verify that we can use set_data(), as well.

[hottwaj]

Thanks guys, will make those changes when I have time over the next few days.

[AlexAndorra]

Hey @hottwaj and @rpgoldman ! Do you know where we are on this? Not trying to be pushy, just being curious -- 😄

[hottwaj]

Hi sorry I'm on holiday this week and will be a bit more pushed for time for next couple of weeks once I'm back at work. Best assume it might be a few more weeks before I can finish off. Hope that's OK, thanks!

…

On Thu, 12 Mar 2020, 19:34 Alexandre ANDORRA, ***@***.***> wrote: Hey @hottwaj <https://github.com/hottwaj> and @rpgoldman <https://github.com/rpgoldman> ! Do you know where we are on this? Not trying to be pushy, just being curious -- 😄 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3816 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABK6JBNGSVGMQUYLN7VAKQLRHETLRANCNFSM4K4BZMNA> .

[AlexAndorra]

Hi @hottwaj ! Do you think you'll be able to find some time to finish up this PR? Or do you need me to take over?
The 3.9 release is approaching and it'd be nice to ship it with this new feature 😃

[hottwaj]

Hi Alex, sorry for not making any further progress... Between work and childcare things have been difficult since the UK went into lockdown! I am still a bit too busy to set aside time for this in the short term, feel free to take over and I hope the little I did was useful... If you end up parking it for a bit longer let me know and I can hopefully revisit in another couple of weeks. Thanks!

[AlexAndorra]

I completely understand @hottwaj, the last couple of weeks have indeed been difficult. I'll take this PR over then, and try to push it through for 3.9 😉
Thanks for the work you did, it's definitely helpful! Good luck for the coming weeks and stay safe 😷

[hottwaj]

Great thanks, and hopefully I said this before but thanks for your work on this awesome tool!

[AlexAndorra]

Closing in favor of #3925