Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set EM_PKG_CONFIG_PATH to correctly configure pkg-config #52

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

swnf
Copy link
Contributor

@swnf swnf commented Nov 7, 2024

Closes #51

Copy link
Member

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks!

@hoodmane
Copy link
Member

hoodmane commented Nov 7, 2024

@ryanking13 you have any thoughts?

@ryanking13
Copy link
Member

Looks okay to me, but could you please test it with your PR to verify (pyodide/pyodide#5154)?

You can change the pyodide-build version used in our PR (https://pyodide.org/en/latest/development/maintainers.html#updating-pyodide-build)

@swnf
Copy link
Contributor Author

swnf commented Nov 7, 2024

I pushed a new commit to pyodide/pyodide#5154 that uses the updated pyodide-build

Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you please update the changelog?

@swnf
Copy link
Contributor Author

swnf commented Nov 11, 2024

@ryanking13 I don't think this PR is ready to be merged. The second commit I pushed to fix random pipeline failures might be related to a scipy test failure (pipeline failed three times). I will try to investigate this issue and add a changelog after that.

@swnf
Copy link
Contributor Author

swnf commented Nov 12, 2024

The pipeline failure seems to be caused by two issues with scipy:

  • The file libopenblas.so is not included in the wheel
  • The openblas build script patches dist/libopenblas.so to include libf2c (static library). But scipy explicitly uses $WASM_LIBRARY_DIR/lib/libopenblas.so which is not patched. This causes the libf2c symbols (like s_cmp) to be missing.

I've pushed a64975df to my PR pyodide/pyodide#5154 to fix this. The pipeline is now green. I have no clue why the build worked before or what exactly broke it.

This PR should now be ready to be merged. I've rebased it on main and updated the changelog.

@ryanking13 ryanking13 merged commit 4a82b7f into pyodide:main Nov 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg-config does not find dependencies in library_install_prefix
3 participants