-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set EM_PKG_CONFIG_PATH to correctly configure pkg-config #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, thanks!
@ryanking13 you have any thoughts? |
Looks okay to me, but could you please test it with your PR to verify (pyodide/pyodide#5154)? You can change the pyodide-build version used in our PR (https://pyodide.org/en/latest/development/maintainers.html#updating-pyodide-build) |
I pushed a new commit to pyodide/pyodide#5154 that uses the updated pyodide-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Could you please update the changelog?
@ryanking13 I don't think this PR is ready to be merged. The second commit I pushed to fix random pipeline failures might be related to a scipy test failure (pipeline failed three times). I will try to investigate this issue and add a changelog after that. |
The pipeline failure seems to be caused by two issues with scipy:
I've pushed a64975df to my PR pyodide/pyodide#5154 to fix this. The pipeline is now green. I have no clue why the build worked before or what exactly broke it. This PR should now be ready to be merged. I've rebased it on |
Closes #51