-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to skip emscripten version check #53
Conversation
I think we should still check for (and allow) "-git" in the version string in addition to this change. |
Right. Let's fix it in this PR too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ryanking13!
Co-authored-by: Agriya Khetarpal <[email protected]>
for more information, see https://pre-commit.ci
Thanks for the review! |
Adds an option to skip emscripten version check. A user can either set
SKIP_EMSCRIPTEN_VERSION_CHECK
env variable, orskip_emscripten_version_check
in the toml file.I think it is useful in following scenarios:
Of course, these scenarios will not work if two versions of Emscripten are incompatible. But I think it is useful to provide this option as not always