Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip emscripten version check #53

Merged
merged 6 commits into from
Nov 9, 2024

Conversation

ryanking13
Copy link
Member

Adds an option to skip emscripten version check. A user can either set SKIP_EMSCRIPTEN_VERSION_CHECK env variable, or skip_emscripten_version_check in the toml file.

I think it is useful in following scenarios:

  • When we update the Emscripten version in Pyodide but it is not released yet, so a user wants to build a package against newer emscripten version.
  • When a user needs a newer version of Emscripten to make their package work. But the Emscripten version in Pyodide is not updated yet.

Of course, these scenarios will not work if two versions of Emscripten are incompatible. But I think it is useful to provide this option as not always

@agriyakhetarpal
Copy link
Member

agriyakhetarpal commented Nov 7, 2024

I think we should still check for (and allow) "-git" in the version string in addition to this change.

@ryanking13
Copy link
Member Author

I think we should still check for (and allow) "-git" in the version string in addition to this change.

Right. Let's fix it in this PR too.

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ryanking13!

CHANGELOG.md Outdated Show resolved Hide resolved
@ryanking13
Copy link
Member Author

Thanks for the review!

@ryanking13 ryanking13 merged commit f78d587 into pyodide:main Nov 9, 2024
4 checks passed
@ryanking13 ryanking13 deleted the option-skip-emscripten branch November 9, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants