Ruff comprehensions and performance

[cclauss]

Upgrade ruff to the current version.

Complete the compliance with Pylint rules.

Add various list, dict, set comprehension, and performance improvements.

• https://docs.astral.sh/ruff/rules/#flake8-comprehensions-c4
• https://docs.astral.sh/ruff/rules/#perflint-perf

[agriyakhetarpal]

Hi @cclauss, thanks for adding these rules! I'm a bit perplexed about setting check=False for all of the subprocess.run() calls, is there a reason in particular for doing so?

[cclauss]

Should this be upgraded to py312?

pyodide-build/pyproject.toml

Line 135 in 9109741

target-version = "py311"

[agriyakhetarpal]

Many of these can be check=True (which I feel in Python should be the better default) except for where we already check for the result in the next stage of a command.

[hoodmane]

These changes look good but should we blanket exclude vendor from linting? cc @ryanking13

[ryanking13]

Yeah I think we should exclude vendor directory from being linted.

[hoodmane]

Thanks @cclauss looks good to me other than a few places where we check=True should be check=False which I've marked.

[hoodmane]

Okay the last thing this needs is revert changes to vendor and exclude vendor from all lint rules.

[agriyakhetarpal]

Thanks for the changes, @cclauss and @hoodmane for correcting me!

[agriyakhetarpal]

Should this be upgraded to py312?

pyodide-build/pyproject.toml

Line 135 in 9109741

target-version = "py311"

Sorry, I missed this. Yes, I think we should do this, pyupgrade might be able to catch a few more things with it.

[hoodmane]

Thanks @cclauss!