chore: drop python 3.6 for cibuildwheel driver #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayeut
force-pushed
the
python-3.7
branch
2 times, most recently
from
5654a1b
to
47e7aef
Compare
joerick
reviewed
Jul 14, 2022
henryiii
reviewed
Jul 14, 2022
henryiii
reviewed
Jul 14, 2022
| @@ -37,6 +32,8 @@ repos: | |||
| rev: 5.10.1 | |||
| hooks: | |||
| - id: isort | |||
| args: ["-a", "from __future__ import annotations"] | |||
There was a problem hiding this comment.
You added this before I could suggest it. :D
joerick
approved these changes
Jul 14, 2022
henryiii
approved these changes
Jul 14, 2022
|
Let's hold this until after the next patch release (2.8.1) |
This drops python 3.6 for cibuildwheel. Building python 3.6 packages is still supported.
test_build_default_launches was using cibuildwheel setup.cfg which led to the test failing once python 3.6 was dropped. Use an empty package, provided by fake_package_dir, to run the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops python 3.6 for cibuildwheel.
Building python 3.6 packages is still supported.
closes #508