Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid RecursionError on Windows #1253

Merged
merged 1 commit into from
Sep 4, 2022
Merged

avoid RecursionError on Windows #1253

merged 1 commit into from
Sep 4, 2022

Conversation

maxbachmann
Copy link
Contributor

This fixes #1252 by using a similar implementation to the one in build_in_directory

@maxbachmann
Copy link
Contributor Author

The ci timed out

joerick
joerick approved these changes Sep 3, 2022
View reviewed changes
Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks fine to me

@henryiii
Copy link
Contributor

henryiii commented Sep 4, 2022

This needs a comment otherwise it might get ”cleaned up” later and rebroken.

@joerick joerick merged commit 2dfeb94 into pypa:main Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii approved these changes

@joerick joerick joerick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

github actions recursion error
3 participants
@maxbachmann @henryiii @joerick