chore: use uv pip compile #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The manylinux tags latest thing is broken on other PRs too. |
henryiii
force-pushed
the
henryiii/chore/uv
branch
from
ab559ae
to
ac63866
Compare
|
reported that issue over on manylinux- pypa/manylinux#1581 |
|
Is it only manylinux1? We could just skip if this happens. |
henryiii
force-pushed
the
henryiii/chore/uv
branch
from
3d3c5b7
to
f82e4a4
Compare
joerick
approved these changes
Mar 15, 2024
noxfile.py
Outdated
| env = os.environ.copy() | ||
| # CUSTOM_COMPILE_COMMAND is a pip-compile option that tells users how to | ||
| # regenerate the constraints files | ||
| env["CUSTOM_COMPILE_COMMAND"] = f"nox -s {session.name}" |
There was a problem hiding this comment.
Not critical, but it looks like this isn't having an effect on uv yet, found an issue here- astral-sh/uv#1527
There was a problem hiding this comment.
It's added now. Though IMO it's not really required, as unlike before, you don't need any special setup to compile it.
There was a problem hiding this comment.
It's called UV_CUSTOM_PIP_COMPILE, even though PR and release notes get it wrong. astral-sh/uv#2554
|
We can, but it would require the latest version of nox. |
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/chore/uv
branch
from
2a040f4
to
bb1f0d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cuts the time down from 40 seconds to 4 seconds, and doesn't require pre-installing every version of Python. It also is easy to run without nox too, since it's now just a simple command that doesn't require a Python version present.
It also adds a lock on importlib-metadata on older Pythons; build does require importlib-metadata on older Pythons, so guessing pip-tools just missed this?
This fixes running the noxfile with uv, too, and silences an incorrect warning from pylint.