-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Python 3.13 beta 1 #1815
Conversation
(Coming from Edit: This should be supported in wheel 0.43. |
Tag parsing is done via the vendored |
Can you confirm which version of |
It seems to be only on Windows, and it's (at least) these four tests:
I see a (3.12) venv seeded with 0.37.1, though the isolated build shouldn't pick up this cached version from what I understand. I think it's only failing on Windows, I'm rerunning with fail-fast off to check, though. |
The issue comes from cibuildwheel. Reproduced there: https://github.com/mayeut/sandbox/actions/runs/9029260391 |
@henryiii, I'll force push and overwrite your commits with something else. |
df7e3ad
to
0d88011
Compare
maybe we ought to get the fixes / changes in the last 3 commits in another PR to discuss those changes ? |
Might make sense, yes. I don't think we should be injecting or pinning setuptools/wheel; if someone is building on Python 3.12 or 3.13 and doesn't have a pyproject.toml, I think they should be required to pip install setuptools and wheel in |
134d464
to
5a30236
Compare
Let's try to start building with python 3.13