Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: free-threaded Python for macOS, MACOSX_DEPLOYMENT_TARGET updates #1854

Merged
merged 13 commits into from
Jun 8, 2024

Conversation

cibuildwheel-bot[bot]
Copy link
Contributor

@cibuildwheel-bot cibuildwheel-bot bot commented Jun 6, 2024

Update the versions of our dependencies.

PR generated by "Update dependencies" workflow.

Close #1855.

@henryiii henryiii marked this pull request as draft June 6, 2024 06:23
henryiii and others added 2 commits June 7, 2024 00:06
@henryiii
Copy link
Contributor

henryiii commented Jun 7, 2024

@mattip Do you know what the min macOS version is for pypy3.8? It looks like the last pypy3.7 supported 10.9: https://github.com/pypy/pypy/blob/cd05c8669313d29d531e2a74b63756467cf23bf9/pypy/doc/release-v7.3.8.rst#L137. But https://www.pypy.org/download.html seems to indicate 10.15 is now the minimum, so is it 10.9 for 3.7 and 3.8 and 10.15 now? I'm asking because CPython just moved from 10.9 to 10.13 as the minimum version with 3.13, so I'm looking at updating these minimums. (CPython puts 11 in the file name for ARM reasons, but it's actually 10.9 and now 10.13).

Signed-off-by: Henry Schreiner <[email protected]>
@mattip
Copy link
Contributor

mattip commented Jun 7, 2024

Please drop support for pyyp3.7, pypy3.8 as soon as possible, they are unsupported.

3,7, 3.8 sets MACOSX_DEPLOYMENT_TARGET to 10.9

3.9, 3.10 on macos-x86_64 should use minimum 10.15, due to pypy/pypy#3879. But I see the sysconfig MACOS_DEPLOYMENT_TARGET in those is 10.13, which is wrong. I opened pypy/pypy#4975 to fix this going forward.

arm64 is of course 11.0 and up.

Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii force-pushed the update-dependencies-pr branch 2 times, most recently from cbc7f4c to 48e702f Compare June 7, 2024 05:44
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii changed the title [Bot] Update dependencies feat: free-threaded Python for macOS, MACOSX_DEPLOYMENT_TARGET updates Jun 7, 2024
@henryiii henryiii marked this pull request as ready for review June 7, 2024 07:06
@henryiii
Copy link
Contributor

henryiii commented Jun 7, 2024

@mayeut or @joerick or @Czaki, anyone want to provide a second set of eyes? I think this is ready. Two changes: updated for the free-threaded build using python/cpython#120098 (fantastic resource, by the way), and adjusted the MACOSX_DEPLOYMENT_TARGET to match the various CPython and PyPy minimums; it is also now clamped, cibuildwheel will raise it if it's too low. This is helpful if someone has 10.x (x<13) set and tries to build 3.13 wheels.

.github/workflows/test.yml Outdated Show resolved Hide resolved
henryiii and others added 2 commits June 7, 2024 16:35
Co-authored-by: Matthieu Darbois <[email protected]>
Co-authored-by: Matthieu Darbois <[email protected]>
cibuildwheel/macos.py Outdated Show resolved Hide resolved
@henryiii
Copy link
Contributor

henryiii commented Jun 8, 2024

Okay to go in? Needs to go in before the next auto bump, or I'll have to revert it from my local checkout. ;)

@henryiii henryiii mentioned this pull request Jun 8, 2024
@mayeut mayeut merged commit 130fdd2 into main Jun 8, 2024
23 of 24 checks passed
@mayeut mayeut deleted the update-dependencies-pr branch June 8, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Min macOS version
3 participants