Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIBW_ENVIRONMENT #21

Merged
merged 19 commits into from
Sep 7, 2017
Merged

CIBW_ENVIRONMENT #21

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
38f89e9
Added test for environment and a script for local running
joerick Jul 24, 2017
6aba5f8
Add a Linux implementation of environment
joerick Jul 24, 2017
573098f
Mac/Windows stubs and test case for environment inheritance
joerick Aug 14, 2017
fd385a9
Add some tests for the environment functionality
joerick Aug 30, 2017
5ae4da6
Add environment code satisfying unit test
joerick Sep 1, 2017
9091533
Run the unit tests in CI
joerick Sep 1, 2017
fcb681d
Use parse_environment in the main code
joerick Sep 1, 2017
f64cb35
Merge remote-tracking branch 'origin/master' into environment
joerick Sep 1, 2017
f56ddda
Make shell evals work and add tests for that
joerick Sep 2, 2017
7229dde
Windows uses a different pathsep so have to use that in the test
joerick Sep 2, 2017
60ed370
Semicolons need quoting
joerick Sep 3, 2017
a7c7a58
Reducing code duplication in bin/run_test.py and bin/run_tests.py
YannickJadoul Sep 6, 2017
3188c97
Fixing 'ValueError: Attempted relative import in non-package'
YannickJadoul Sep 6, 2017
93d2a59
Making call from run_tests to run_test subprocess.check_call
YannickJadoul Sep 6, 2017
be474fd
Fix string splitting for the env string
joerick Sep 6, 2017
b18684a
Merge branch 'environment' of github.com:joerick/cibuildwheel into en…
joerick Sep 6, 2017
34e8ee0
Fix empty env string case
joerick Sep 6, 2017
7c41632
Add CIBW_ENVIRONMENT to README and reorder options
joerick Sep 6, 2017
523dfc0
Fix some linter warnings
joerick Sep 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/run_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import os, sys, subprocess, shutil, json
from glob import glob

from . import run_test
import run_test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if there is a better way of doing this 'import from the same folder'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there isn't. Also since these are utility scripts I'd prefer using the shell interface instead, something like subprocess.check_call([sys.executable, 'bin/run_test.py', arg1, arg2])

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There you go, then. I'd chosen for this such that the whole argument parsing (and extra output 'Project built successfully.') was not executed every time.

Have a look, maybe the if __name__ == '__main__': construction was also unnecessary, then.


if __name__ == '__main__':
# move cwd to the project root
Expand Down