fix: artificial limiting in pycln breaks on 3.10 #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyCln artificially version-caps Python to <3.10, which broke when pre-commit updated to 3.10 earlier today. I hadn't noticed this, because locally I installed with 3.9, then when brew updated pre-commit to 3.10, it just kept working, because pycln actually supports 3.10, it just follows the horrific practice of adding upper version limits as pushed by Poetry. If the version caps are not removed, I think we should remove this from our pre-commit. Otherwise, this will cause extra headaches every Python upgrade. Temporarily disabling for now. hadialqattan/pycln#81