Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have sdists normalize the version in the file name #1066

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

brettcannon
Copy link
Member

Brought up as part of pypa/packaging#527 .

@bhrutledge bhrutledge merged commit e59950e into pypa:main Mar 29, 2022
@brettcannon brettcannon deleted the sidst-version-normalization branch March 29, 2022 23:05
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6

@woodruffw
Copy link
Member

As a note: does PyPI or any other PEP 503-compliant host currently do the - to _ normalization? The standard here suggests that foo-bar==1.2.3 should be normalized to foo_bar-1.2.3.tar.gz, but here's how PyPI's simple index supplies pip-audit's source distributions (link):

pip-audit-2.1.0.tar.gz
pip-audit-2.1.1.tar.gz
pip-audit-2.2.0.tar.gz
pip-audit-2.2.1.tar.gz

(The current behavior is clearly working since pip has a workaround for the "vexing parse" case in pypa/packaging#527, but I wonder if it makes sense to amend this documentation again to emphasize that the normalization suggested currently isn't practiced.)

@woodruffw
Copy link
Member

I just realized that my above comment is slightly off topic from the PR (since it's about the name component, not the version), so I'll create a separate issue to follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants