Don't put an underscore in the version portion of Python 3.10 compatibility tags #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 24, 2020
|
Unsurprisingly, when this is patched in wheel (vendors packaging.tags) and pip (vendors packaging), it fixes the current breakage (tested couple Fedora packages that were affected). Until (and unless) PEP 641 is approved and implemented, maybe this is a way to go to unblock testing with Python 3.10 early alphas? |
|
I would rather not have to ask the packaging ecosystem to do multiple updates just for this if possible. It doesn't matter quite yet anyway, since any new release is held up on macOS 11/Arm support anyway. |
|
fixes gh-372. Since the PEP was rejected, I think this can move forward. |
pradyunsg
reviewed
Dec 11, 2020
…bility tags PEP 641 is rejected. See https://discuss.python.org/t/5513/42 See https://www.python.org/dev/peps/pep-0641/ Fixes pypa#372 Co-authored-by: Pradyun Gedam <[email protected]>
hroncok
force-pushed
the
tag_no_underscore
branch
from
35b2fe6 to
a625344
Compare
|
Rebased and updated the commit message. Included suggestion by @pradyunsg (thanks). |
di
approved these changes
Dec 11, 2020
brettcannon
approved these changes
Dec 11, 2020
This was referenced Dec 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 641 is rejected.
See https://discuss.python.org/t/5513/42
See https://www.python.org/dev/peps/pep-0641/
Fixes #372