Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] packaging.metadata.Metadata.from_raw(validate=True/False) may return empty result #851

Closed
wants to merge 4 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/packaging/metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -512,10 +512,6 @@ def __get__(self, instance: Metadata, _owner: type[Metadata]) -> T:
value = converter(value)

cache[self.name] = value
try:
del instance._raw[self.name] # type: ignore[misc]
except KeyError:
pass

return cast(T, value)

Expand Down Expand Up @@ -742,13 +738,15 @@ def from_raw(cls, data: RawMetadata, *, validate: bool = True) -> Metadata:
)
exceptions.append(exc)
continue
DEKHTIARJonathan marked this conversation as resolved.
Show resolved Hide resolved
# Access the attribute to trigger validation.
getattr(ins, key)
except InvalidMetadata as exc:
exceptions.append(exc)

if exceptions:
raise ExceptionGroup("invalid metadata", exceptions)

del ins._raw
return ins

@classmethod
Expand Down