You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Traceback (most recent call last):
File "/Users/william/devel/pip-audit/env/bin/pip-audit", line 8, in <module>
sys.exit(audit())
File "/Users/william/devel/pip-audit/pip_audit/_cli.py", line 432, in audit
for (spec, vulns) in auditor.audit(source):
File "/Users/william/devel/pip-audit/pip_audit/_audit.py", line 66, in audit
for dep, vulns in self._service.query_all(specs):
File "/Users/william/devel/pip-audit/pip_audit/_service/interface.py", line 150, in query_all
for spec in specs:
File "/Users/william/devel/pip-audit/pip_audit/_dependency_source/requirement.py", line 104, in collect
assert isinstance(req, EditableRequirement)
AssertionError
...which is:
forreqinrf.requirements:
ifreq.reqisNone:
# For editable requirements that don't have an egg fragment that lists the# the package name and version, `pip-requirements-parser` won't attach a# `Requirement` object to the `InstallRequirement`.## In this case, we can't audit the dependency so we should signal to the# caller that we're skipping it.assertisinstance(req, EditableRequirement)
yieldSkippedDependency(
name=req.requirement_line.line,
skip_reason="could not deduce package/specifier pair from requirement, ""please specify them with #egg=your_package_name==your_package_version",
)
continue
The assert here feels spurious -- we should support URL requirements that aren't marked as editable.
CC @tetsuo-cpp for thoughts, since I think this was your change.
The text was updated successfully, but these errors were encountered:
Yeah, I think that assertion can either be removed or massaged to include this case. I'm about to take a closer look at URL handling so I'll fix this up.
I noticed this while root-causing #349.
The following:
pip-audit -r <(echo 'git+https://github.com/unbit/uwsgi.git@1bb9ad77c6d2d310c2d6d1d9ad62de61f725b824')
fails with:
...which is:
The
assert
here feels spurious -- we should support URL requirements that aren't marked as editable.CC @tetsuo-cpp for thoughts, since I think this was your change.
The text was updated successfully, but these errors were encountered: