Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirement: Remove incorrect assertion around URL requirements without egg fragment #359

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

tetsuo-cpp
Copy link
Contributor

Closes #350

@tetsuo-cpp tetsuo-cpp requested a review from woodruffw August 24, 2022 13:34
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@woodruffw woodruffw enabled auto-merge (squash) August 24, 2022 18:15
@woodruffw woodruffw merged commit 99c4e26 into main Aug 24, 2022
@woodruffw woodruffw deleted the alex/unpinned-vcs-assertion branch August 24, 2022 18:17
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Sep 9, 2022
## [2.4.4]

### Changed

* `pip-audit` is now a PyPA member project, and lives under
  [`pypa/pip-audit`](https://github.com/pypa/pip-audit)!

* Improved error message for when unpinned URL requirements are found during an
  audit with the `--no-deps` flag
  ([#355](pypa/pip-audit#355))

### Fixed

* Fixed an issue where packages on PyPI with no published versions trigger a
  dependency resolution failure instead of being skipped
  ([#357](pypa/pip-audit#357))

* Fixed an incorrect assertion triggering for non-editable URL requirements that
  don't have an egg fragment
  ([#359](pypa/pip-audit#359))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: assertion tripped when auditing a URL-style requirement without egg marker
2 participants