Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pyproject.toml #246

Merged
merged 16 commits into from
Mar 4, 2022
Merged

Support pyproject.toml #246

merged 16 commits into from
Mar 4, 2022

Conversation

tetsuo-cpp
Copy link
Contributor

@tetsuo-cpp tetsuo-cpp commented Mar 3, 2022 •
edited
Loading

Closes #83

  • Unit tests

@tetsuo-cpp tetsuo-cpp marked this pull request as draft March 3, 2022 13:37
di
di reviewed Mar 3, 2022
View reviewed changes
Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a quick pass, I think this looks good except for the CLI. Let's make sure to add documentation w/ examples as well.

pip_audit/_cli.py Outdated Show resolved Hide resolved
@woodruffw woodruffw added component:cli CLI components component:dep-sources Dependency sources enhancement New feature or request labels Mar 3, 2022
@tetsuo-cpp tetsuo-cpp marked this pull request as ready for review March 4, 2022 08:48
@tetsuo-cpp tetsuo-cpp requested review from di and woodruffw March 4, 2022 09:24
woodruffw
woodruffw reviewed Mar 4, 2022
View reviewed changes
pip_audit/_cli.py Outdated Show resolved Hide resolved
woodruffw
woodruffw approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@woodruffw woodruffw merged commit 78e6d5d into main Mar 4, 2022
@woodruffw woodruffw deleted the alex/pyproject-source branch March 4, 2022 15:51
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Mar 14, 2022
@0-wiz-0
py-pip-audit: update to 2.1.0.
3e958ef 
## [2.1.0] - 2022-03-11

### Added

* CLI: The `--skip-editable` flag has been added, allowing users to skip local
  packages or parsed requirements (via `-r`) that are marked as editable
  ([#244](pypa/pip-audit#244))

* CLI: `pip-audit` can audit projects that list their dependencies in
  `pyproject.toml` files, via `pip-audit <dir>`
  ([#246](pypa/pip-audit#246))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

@di di Awaiting requested review from di

Assignees
No one assigned
Labels
component:cli CLI components component:dep-sources Dependency sources enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support pyproject.toml
3 participants
@tetsuo-cpp @di @woodruffw