cli, state: replace progress spinner with rich.status
#283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <[email protected]>
|
Demos: Old: New: Note that the new one has a faster startup, and is generally smoother. |
woodruffw
commented
May 24, 2022
| super().__init__(message=message, **kwargs) | ||
| self._console = Console() | ||
| # NOTE: audits can be quite fast, so we need a pretty high refresh rate here. | ||
| self._spinner = self._console.status(message, spinner="line", refresh_per_second=30) |
There was a problem hiding this comment.
N.B.: If we wanted to be extra fancy, we could allow users to configure the spinner=... here, rather than using the same "line" spinner that progress uses.
Rich has a decent collection of spinners to choose from:
|
The new |
di
approved these changes
May 24, 2022
Signed-off-by: William Woodruff <[email protected]>
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jul 3, 2022
## [2.3.4] ### Fixed * Vulnerability fixing: the `--fix` flag now works for vulnerabilities found in requirement subdependencies. A new line is now added to the requirement file to explicitly pin the offending subdependency ([#297](pypa/pip-audit#297)) ## [2.3.3] ### Changed * CLI: `pip-audit` now warns on the combination of `-s osv` and `--require-hashes`, notifying users that only the PyPI service can fully verify hashes ([#298](pypa/pip-audit#298)) ### Fixed * CLI/Dependency sources: `--cache-dir=...` and other flags that affect dependency resolver behavior now work correctly when auditing a `pyproject.toml` dependency source ([#300](pypa/pip-audit#300)) ## [2.3.2] - 2022-05-14 ### Changed * CLI: `pip-audit`'s progress spinner has been refactored to make it faster and more responsive ([#283](pypa/pip-audit#283)) * CLI, Vulnerability sources: the error message used to report connection failures to vulnerability sources was improved ([#287](pypa/pip-audit#287)) * Vulnerability sources: the OSV service is now more resilient to schema changes ([#288](pypa/pip-audit#288)) * Vulnerability sources: the PyPI service provides a better error message during some cases of service degradation ([#294](pypa/pip-audit#294)) ### Fixed * Vulnerability sources: a bug stemming from an incorrect assumption about OSV's schema guarantees was fixed ([#284](pypa/pip-audit#284)) * Caching: `pip-audit` now respects `pip`'s `PIP_NO_CACHE_DIR` and will not attempt to use the `pip` cache if present ([#290](pypa/pip-audit#290))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the spinner implementation quite a bit, and brings us slightly closer in line with
pip's already vendored dependencies.Closes #282.
Signed-off-by: William Woodruff [email protected]