Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Don't create empty files on failure #432

Merged
merged 5 commits into from
Dec 12, 2022
Merged

Conversation

woodruffw
Copy link
Member

This also fixes a longstanding annoyance of mine in pip-audit --help, which was that --output showed its "default" as None.

Closes #431.

@woodruffw woodruffw added the component:cli CLI components label Dec 12, 2022
@woodruffw woodruffw requested review from di and tetsuo-cpp December 12, 2022 16:15
@woodruffw woodruffw self-assigned this Dec 12, 2022
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw merged commit 33a2ac4 into main Dec 12, 2022
@woodruffw woodruffw deleted the ww/dont-make-empty-outputs branch December 12, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:cli CLI components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip-audit should not create an empty output file when it fails internally
2 participants