Skip to content

Commit

Permalink
remove last user of SafeConfigParser
Browse files Browse the repository at this point in the history
Fixes #5059
  • Loading branch information
xrmx committed Oct 30, 2018
1 parent ebfa663 commit 376abc0
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 1 deletion.
Empty file added news/5059.trivial
Empty file.
2 changes: 1 addition & 1 deletion src/pip/_internal/vcs/mercurial.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def fetch_new(self, dest, url, rev_options):

def switch(self, dest, url, rev_options):
repo_config = os.path.join(dest, self.dirname, 'hgrc')
config = configparser.SafeConfigParser()
config = configparser.RawConfigParser()
try:
config.read(repo_config)
config.set('paths', 'default', url)
Expand Down
28 changes: 28 additions & 0 deletions tests/functional/test_vcs_mercurial.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
"""
Contains functional tests of the Mercurial class.
"""

import os

from pip._vendor.six.moves import configparser

from pip._internal.vcs.mercurial import Mercurial
from tests.lib import need_mercurial


@need_mercurial
def test_mercurial_switch_updates_config_file_when_found(tmpdir):
hg = Mercurial()
options = hg.make_rev_options()
hg_dir = os.path.join(tmpdir, '.hg')
os.mkdir(hg_dir)
config = configparser.RawConfigParser()
config.add_section('paths')
config.set('paths', 'default', 'old_url')
hgrc_path = os.path.join(hg_dir, 'hgrc')
with open(hgrc_path, 'w') as f:
config.write(f)
hg.switch(tmpdir, 'new_url', options)
config.read(hgrc_path)
default_path = config.get('paths', 'default')
assert default_path == 'new_url'

0 comments on commit 376abc0

Please sign in to comment.