Skip to content

Commit

Permalink
Merge pull request #7355 from chrahunt/refactor/remove-unnecessary-tag
Browse files Browse the repository at this point in the history
Remove interpreter-specific major version tag
  • Loading branch information
chrahunt authored Nov 16, 2019
2 parents b224b34 + a2d473f commit 4447cb0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 17 deletions.
4 changes: 4 additions & 0 deletions news/7355.removal
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Remove interpreter-specific major version tag e.g. ``cp3-none-any``
from consideration. This behavior was not documented strictly, and this
tag in particular is `not useful <https://snarky.ca/the-challenges-in-designing-a-library-for-pep-425/>`_.
Anyone with a use case can create an issue with pypa/packaging.
3 changes: 0 additions & 3 deletions src/pip/_internal/pep425tags.py
Original file line number Diff line number Diff line change
Expand Up @@ -433,9 +433,6 @@ def get_supported(

# No abi / arch, but requires our implementation:
supported.append(('%s%s' % (impl, versions[0]), 'none', 'any'))
# Tagged specifically as being cross-version compatible
# (with just the major version specified)
supported.append(('%s%s' % (impl, versions[0][0]), 'none', 'any'))

# No abi / arch, generic Python
for i, version in enumerate(versions):
Expand Down
14 changes: 0 additions & 14 deletions tests/functional/test_download.py
Original file line number Diff line number Diff line change
Expand Up @@ -620,20 +620,6 @@ def test_download_specify_implementation(script, data):
in result.files_created
)

data.reset()
fake_wheel(data, 'fake-1.0-fk2.fk3-none-any.whl')
result = script.pip(
'download', '--no-index', '--find-links', data.find_links,
'--only-binary=:all:',
'--dest', '.',
'--implementation', 'fk',
'fake'
)
assert (
Path('scratch') / 'fake-1.0-fk2.fk3-none-any.whl'
in result.files_created
)

data.reset()
fake_wheel(data, 'fake-1.0-fk3-none-any.whl')
result = script.pip(
Expand Down

0 comments on commit 4447cb0

Please sign in to comment.