Skip to content

Commit

Permalink
Do not download editables while preparing requirements
Browse files Browse the repository at this point in the history
Downloading is done at the end of the download command
just like any other requirement.
  • Loading branch information
sbidoul committed Nov 11, 2020
1 parent a88c84d commit 5760ea8
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion src/pip/_internal/commands/download.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def run(self, options, args):

downloaded = [] # type: List[str]
for req in requirement_set.requirements.values():
if not req.editable and req.satisfied_by is None:
if req.satisfied_by is None:
assert req.name is not None
preparer.save_linked_requirement(req)
downloaded.append(req.name)
Expand Down
1 change: 0 additions & 1 deletion src/pip/_internal/operations/prepare.py
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,6 @@ def prepare_editable_requirement(
req, self.req_tracker, self.finder, self.build_isolation,
)

req.archive(self.download_dir)
req.check_if_exists(self.use_user_site)

return dist
Expand Down

0 comments on commit 5760ea8

Please sign in to comment.