Skip to content

Commit

Permalink
responded to comments
Browse files Browse the repository at this point in the history
  • Loading branch information
omry committed Aug 3, 2019
1 parent ec47c86 commit 6dd5727
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion docs/html/reference/pip_install.rst
Original file line number Diff line number Diff line change
Expand Up @@ -701,7 +701,7 @@ You can install local projects by specifying the project path to pip::

$ pip install path/to/SomeProject

During the installation, pip will copy the entire project directory to a temporary location and install from there.
During regular installation, pip will copy the entire project directory to a temporary location and install from there.
The exception is that pip will exclude .tox and .nox directories present in the top level of the project from being copied.


Expand Down
22 changes: 11 additions & 11 deletions tests/unit/test_download.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from pip._internal.models.link import Link
from pip._internal.utils.hashes import Hashes
from pip._internal.utils.misc import path_to_url
from tests.lib import Path, create_file
from tests.lib import create_file


@pytest.fixture(scope="function")
Expand Down Expand Up @@ -420,21 +420,21 @@ def test_unpack_file_url_thats_a_dir(self, tmpdir, data):
def test_unpack_file_url_excludes_expected_dirs(tmpdir, exclude_dir):
src_dir = tmpdir / 'src'
dst_dir = tmpdir / 'dst'
src_included_file = Path.joinpath(src_dir, 'file.txt')
src_excluded_dir = Path.joinpath(src_dir, exclude_dir)
src_excluded_file = Path.joinpath(src_dir, exclude_dir, 'file.txt')
src_included_dir = Path.joinpath(src_dir, 'subdir', exclude_dir)
src_included_file = src_dir.joinpath('file.txt')
src_excluded_dir = src_dir.joinpath(exclude_dir)
src_excluded_file = src_dir.joinpath(exclude_dir, 'file.txt')
src_included_dir = src_dir.joinpath('subdir', exclude_dir)

# set up source directory
src_excluded_dir.mkdir(parents=True)
src_included_dir.mkdir(parents=True)
Path.touch(src_included_file)
Path.touch(src_excluded_file)
src_included_file.touch()
src_excluded_file.touch()

dst_included_file = Path.joinpath(dst_dir, 'file.txt')
dst_excluded_dir = Path.joinpath(dst_dir, exclude_dir)
dst_excluded_file = Path.joinpath(dst_dir, exclude_dir, 'file.txt')
dst_included_dir = Path.joinpath(dst_dir, 'subdir', exclude_dir)
dst_included_file = dst_dir.joinpath('file.txt')
dst_excluded_dir = dst_dir.joinpath(exclude_dir)
dst_excluded_file = dst_dir.joinpath(exclude_dir, 'file.txt')
dst_included_dir = dst_dir.joinpath('subdir', exclude_dir)

src_link = Link(path_to_url(src_dir))
unpack_file_url(
Expand Down

0 comments on commit 6dd5727

Please sign in to comment.