Merge pull request #5671 from segevfiner/ascii-progress-bar-fix

Make the ascii progress bar really be ascii, not Unicode
pypa · Jul 6, 2019 · d4f0f4e · d4f0f4e
2 parents 8e26b83 + b0a6737
commit d4f0f4e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/news/5671.bugfix b/news/5671.bugfix
@@ -0,0 +1 @@
+Make the "ascii" progress bar really be "ascii" and not Unicode.
diff --git a/src/pip/_internal/utils/ui.py b/src/pip/_internal/utils/ui.py
@@ -208,8 +208,8 @@ class DownloadSilentBar(BaseDownloadProgressBar, SilentBar):  # type: ignore
     pass
 
 
-class DownloadIncrementalBar(BaseDownloadProgressBar,  # type: ignore
-                             IncrementalBar):
+class DownloadBar(BaseDownloadProgressBar,  # type: ignore
+                  Bar):
     pass
 
 
@@ -252,7 +252,7 @@ def update(self):
 BAR_TYPES = {
     "off": (DownloadSilentBar, DownloadSilentBar),
     "on": (DefaultDownloadProgressBar, DownloadProgressSpinner),
-    "ascii": (DownloadIncrementalBar, DownloadProgressSpinner),
+    "ascii": (DownloadBar, DownloadProgressSpinner),
     "pretty": (DownloadFillingCirclesBar, DownloadProgressSpinner),
     "emoji": (DownloadBlueEmojiProgressBar, DownloadProgressSpinner)
 }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Make the "ascii" progress bar really be "ascii" and not Unicode.