Removing duplicated names in AUTHORS.txt

[pradyunsg]

I noticed that a few people would get duplicated names in AUTHORS.txt. I think it would be a good idea to avoid duplication in the AUTHORS.txt file if possible.

I'll post the following on this issue if @pypa/pip-committers think we should de-duplicate it...

To the following, I ask: Which email do you want associated with your name in AUTHORS.txt?

@atdaemon: [email protected] or [email protected]
@vartec: [email protected] or [email protected]
@kuzmiigo: [email protected] or [email protected]
@luojiebin: [email protected] or [email protected]
@StephanErb: [email protected] or [email protected] 
@takluyver: [email protected] or [email protected]

[pradyunsg]

Putting this in 10.0 since, well, it's sort of a "pre-release" task. :)

[pradyunsg]

Ping? @pypa/pip-committers

(sorry if the pings are annoying)

[pfmoore]

What sort of feedback are you after? I've no problem with it being done, as you say the key is getting the details from people as to what they want us to do. Conversely, I don't think it's crucial, so if no-one gets round to doing it, or we can't get in touch with any of the contributors, it's not the end of the world.

[pradyunsg]

I'm just thinking of doing a GitHub mention. I don't really care about it all that much. It's just one of those nice-to-have things. Not on a critical path of anything.

…

On Wed, 24 Jan 2018, 14:25 Paul Moore, ***@***.***> wrote: What sort of feedback are you after? I've no problem with it being done, as you say the key is getting the details from people as to what they want us to do. Conversely, I don't think it's crucial, so if no-one gets round to doing it, or we can't get in touch with any of the contributors, it's not the end of the world. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#4891 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADH7SVLSxN9KPqb86Rueh3J-AMeDD2YPks5tNvAVgaJpZM4QqjUF> .

[pfmoore]

Ah. Doesn't including @-names in quoted text do a mention? I didn't realise that. Yeah, go for it :-)

[pradyunsg]

To the following, I ask: Which email do you want associated with your name in AUTHORS.txt?

@atdaemon: [email protected] or [email protected]
@vartec: [email protected] or [email protected]
@kuzmiigo: [email protected] or [email protected]
@luojiebin: [email protected] or [email protected]
@StephanErb: [email protected] or [email protected]
@takluyver: [email protected] or [email protected]

[kuzmiigo]

[email protected] for @kuzmiigo. Thank you.

[takluyver]

Thanks for checking. I prefer [email protected] .

[atdaemon]

[email protected] for @atdaemon.
Thank you!

[StephanErb]

for @StephanErb please use [email protected]. Thanks!

[vartec]

@vartec - [email protected]

[pfmoore]

@pradyunsg Are you going to produce a PR for this?

[pradyunsg]

On it now.

[pradyunsg]

@xavfernandez What about you?

Which one do you want in the AUTHORS file?

Xavier Fernandez <[email protected]>
Xavier Fernandez <[email protected]>

[pradyunsg]

Which email do you want associated with your name in the AUTHORS file?

@vstinner:

Victor Stinner <[email protected]>
Victor Stinner <[email protected]>

@radiosilence:

James Cleveland <[email protected]>
James Cleveland <[email protected]>

[pfmoore]

@pradyunsg One thing I just noticed. AUTHORS.txt is a generated file (see https://pip.pypa.io/en/latest/development/#release-process). So I'm not sure how you're planning on implementing this, but a simple edit of AUTHORS.txt isn't going to work...

[vstinner]

If you want to keep a single email, you can use my gmail.com address.

[dstufft]

the generation of AUTHORS.txt supports the .mailmap file https://github.com/pypa/pip/blob/master/.mailmap

[dstufft]

https://stacktoheap.com/blog/2013/01/06/using-mailmap-to-fix-authors-list-in-git/

[pradyunsg]

Yep. Mailmap is what I've modified.

…

On Mon, 26 Mar 2018, 20:47 Donald Stufft, ***@***.***> wrote: https://stacktoheap.com/blog/2013/01/06/using-mailmap-to-fix-authors-list-in-git/ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4891 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADH7STa5x0TU13t5Y-Nqt8jkQ2jMXHYkks5tiQaUgaJpZM4QqjUF> .

[pfmoore]

Cool. Sorry for the noise.

[pradyunsg]

There's still a few more:

Stéphane Bidoul (ACSONE) <[email protected]>
Stéphane Bidoul <[email protected]>

Xavier Fernandez <[email protected]>
Xavier Fernandez <[email protected]>

Roy Wellington Ⅳ <[email protected]>
Roy Wellington Ⅳ <[email protected]>

Rohan Jain <[email protected]>
Rohan Jain <[email protected]>
Rohan Jain <[email protected]>

Kenneth Reitz <[email protected]>
Kenneth Reitz <[email protected]>

James Cleveland <[email protected]>
James Cleveland <[email protected]>

Ian Wienand <[email protected]>
Ian Wienand <[email protected]>

Ernest W Durbin III <[email protected]>
Ernest W. Durbin III <[email protected]>

[xanderyzwich]

@xavfernandez @thanatos @crodjer @radiosilence @ianw @kennethreitz please let us know which email you would prefer

[kennethreitz]

[email protected]

[vstinner]

It's painful to keep a list of email address up to date. The Misc/ACKS file of the Python project only list (full) names with no email address.

I like https://thanks.rust-lang.org/ This website only lists names, no email address.

By the way, I'm not sure that it's a good practice to have an up to date list of email addresses, because spams are a major issue nowadays ;-)

[xanderyzwich]

I don't think that there is an intention to upkeep CURRENT email addresses. The list just contained duplicates, and as these did not have the same email address then there was a desire to allow them to choose the desired address.

[ianw]

Similar to @vstinner point; IIRC contributions that came from my @redhat.com were done on Red Hat time, while those done at @wienand.org weren't. It's a minor thing but still sort of representative; blank names avoids that (much as the file is needed at all with git history...).

To the question, I think just keep @wienand.org as I'm not planning on changing my name ;)

[xanderyzwich]

@pradyunsg with all of the comments seen above, is there really still a need to maintain the email addresses of contributors?

[crodjer]

Can you please use: Rohan Jain <[email protected]>

[pradyunsg]

I won't mind dropping emails since the mismatch is from the emails itself and spam is definitely something I don't want people to be sent. It should not be too difficult to switch.

@pypa/pip-committers Thoughts on dropping emails from the authors list. Aside, let's also make it more visible like Rust by putting it in the docs like the NEWS?

[pradyunsg]

Accidentally pressed close instead of what my keyboard predicted.

[pfmoore]

@pradyunsg Fine with me - although I'm not really sure it's something we should decide unilaterally, it's really something the contributors themselves should have a say in, surely?

[xanderyzwich]

Is there any reason why contributors file is even needed when github includes this : https://github.com/pypa/pip/graphs/contributors

[pradyunsg]

Is there any reason why contributors file is even needed

The AUTHORS.txt is shipped with pip's source distribution, which in turn is referenced from LICENSE.txt.

I'm not really sure it's something we should decide unilaterally, it's really something the contributors themselves should have a say in, surely?

@pfmoore Yep. I feel a little uncomfortable just changing the format without asking, especially because it's referenced from the LICENSE and I'm very much not a lawyer. The only way that I can think of doing it is spamming everyone with a mail, which is a bad idea since those emails are definitely not upto date. ;)

It should not be too difficult to switch.

Now that I think of it, the case of 2 people having the same name and different email isn't much different from the same person having a duplicate email address. I guess we'd still have to ask about the email situation anyway so it'd still be a one-time pain.

---

Let's keep this issue for solely asking questions to remove duplicates (because we're @ mentioning a lot of people) and move the discussion for dropping emails to a different issue -- #5979 -- and for adding the list to pip's docs -- #5980.

[pradyunsg]

Okay, coming back around to this, I don't think there's a lot of merit in doing this.

Thanks everyone who did indeed respond. Let's do #5980 and then we can look into what else we might want to do about the author list. :)