Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --color=yes for pytest to color output logs #10126

Merged
merged 1 commit into from
Jul 4, 2021
Merged

Add --color=yes for pytest to color output logs #10126

merged 1 commit into from
Jul 4, 2021

Conversation

harupy
Copy link
Contributor

@harupy harupy commented Jul 4, 2021 •
edited
Loading

Add --color=yes for pytest to color output logs and make it easier to find errors / warnings.

@uranusjr
Copy link
Member

uranusjr commented Jul 4, 2021

Could you modify something in the tests directory to trigger CI so we can see how this would work? We can remove it afterwards.

@harupy
Copy link
Contributor Author

harupy commented Jul 4, 2021

BEFORE

image

AFTER

Screen Shot 2021-07-04 at 22 06 02

@pradyunsg
Copy link
Member

@harupy Nice! Thanks for doing this.

Could you squash the commits and drop the dummy changes now?

@harupy
Copy link
Contributor Author

harupy commented Jul 4, 2021 •
edited
Loading

@pradyunsg Sure!

@pradyunsg pradyunsg merged commit f37fc4c into pypa:main Jul 4, 2021
@pradyunsg
Copy link
Member

MOAR COLORS! 🎉

@harupy harupy deleted the color-pytest branch July 4, 2021 13:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harupy @uranusjr @pradyunsg