Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2020 ux docs #10133

Closed
wants to merge 13 commits into from
Closed

Add 2020 ux docs #10133

wants to merge 13 commits into from

Conversation

nlhkabu
Copy link
Member

@nlhkabu nlhkabu commented Jul 5, 2021

Preview
https://pip--10133.org.readthedocs.build/en/10133/ux-research-design/

TODO

  • Cleanup markdown
  • Ensure all links are working and point to the right place
  • Make sure images and working, including alt-text

Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY! I'm very happy to see this! ^>^

@@ -0,0 +1,7 @@
# UX Research & Design
Copy link
Member

@pradyunsg pradyunsg Jul 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to also update docs/html/index.md. It currently references ux_research_design which should be updated to ux_research_design/index.

Further, you might want to a "toctree" similar to that page, listing all the sub-documents, if you want them to show up in the sidebar.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks @pradyunsg, will do.
I wasn't clear if it should be ux_research_design/index or ux-research-design/index?
The folder is ux-research-design should I change it to ux_research_design ?

Copy link
Member

@pradyunsg pradyunsg Jul 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't notice.

ux_research_design/index or ux-research-design/index

It just needs to match the folder name. We can use this opportunity to clean up the folder name -- we should setup a redirect from the underscore based name to the dashed name -- I can do that in a follow up.

The folder is ux-research-design should I change it to ux_research_design ?

Nah. The main benefit would be that the URL is preserved, but I don't think we care that much, given that adding a redirect is cheap.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(editted the last comment extensively, in case someone's following via email)

@pradyunsg pradyunsg added the type: docs Documentation related label Jul 6, 2021
@nlhkabu nlhkabu force-pushed the add-2020-ux-docs branch from 750899c to 88c59ce Compare July 18, 2021 13:46
@nlhkabu nlhkabu force-pushed the add-2020-ux-docs branch from 8c809e2 to 5993131 Compare July 18, 2021 14:46
@nlhkabu
Copy link
Member Author

nlhkabu commented Jul 21, 2021

@pradyunsg are you able to point me in the right direction:
I have several pages that are not exposed in the menu, but sit in the '2020-research-outputs' folder.
I want to link to them from the html tables in research-results.md - see https://pip--10133.org.readthedocs.build/en/10133/ux-research-design/research-results/#research-results
I am having trouble working out what the URLs should be, or how to reference them correctly. Do you know how I can do this? Thanks!

@pradyunsg
Copy link
Member

pradyunsg commented Jul 23, 2021

I am having trouble working out what the URLs should be, or how to reference them correctly.

The way I would reference them is to use Markdown links + make this a Markdown table; but I trust your judgement on whether that's better. I think [About our users](2020-research-outputs/about-our-users) should generate the correct link.

The other option would be to change the URL we're using in the a[href] tags:

-<a href="2020-research-outputs/override-conflicting-dependencies">
+<a href="../2020-research-outputs/override-conflicting-dependencies">

I haven't tested either of these though -- I am speaking based off of my understanding of how Sphinx's linking logic / output generation works.

@pradyunsg
Copy link
Member

If you're wondering what the CI failures are, those are due to trailing whitespace in a bunch of these files: https://github.com/pypa/pip/runs/3128618975#step:4:59

@nlhkabu
Copy link
Member Author

nlhkabu commented Jul 23, 2021

Thanks @pradyunsg - I have cleaned up the hyperlinks as suggested.
re: whitespace - I am still to work through a number of the files in /2020-research-outputs - some were written in Google Docs and have been exported to .md and will need a lot of cleanup!

@nlhkabu nlhkabu force-pushed the add-2020-ux-docs branch from 176bf14 to dcffff7 Compare July 23, 2021 20:10
@pradyunsg
Copy link
Member

pradyunsg commented Jul 23, 2021

I have several pages that are not exposed in the menu, but sit in the '2020-research-outputs' folder.

The sidebar is populated by the {toctree} code blocks. Basically, to have the files show up in the sidebar, you'd need to include them in one of those blocks.

What I would suggest doing is adding the following wherever you want in the research-results.md

```{toctree}
:hidden:

2020-research-outputs/about-our-users
2020-research-outputs/ci-cd
2020-research-outputs/improving-pips-documentation
2020-research-outputs/mental-models
2020-research-outputs/override-conflicting-dependencies
2020-research-outputs/personas
2020-research-outputs/pip-force-reinstall
2020-research-outputs/pip-logo
2020-research-outputs/pip-search
2020-research-outputs/pip-upgrade-conflict
2020-research-outputs/prioritizing-features
2020-research-outputs/users-and-security
```

These are relative paths, you can optionally include .md in them as well.

I think you can probably remove the :hidden: and use this as a substitute for the table, if you think just a list with the page titles is enough. :)

@pradyunsg
Copy link
Member

If you wanna know more details about the whole {toctree} thing, you can find them under "Table of Contents" here: https://www.jetbrains.com/pycharm/guide/tutorials/sphinx_sites/more_authoring/

(Jetbrains didn't include anchors in headings 🤷🏽‍♂️)

@nlhkabu
Copy link
Member Author

nlhkabu commented Jul 28, 2021

Thanks @pradyunsg - Links are now working...
I don't actually want the results pages to display in the menu - and prefer the table structure to a TOC.

Question: do we have any preference of where we want to host images? Right now I have some on GitHub and others on imgur.com

@pradyunsg
Copy link
Member

I don't actually want the results pages to display in the menu

Ah, whoops, I misunderstood. :)

do we have any preference of where we want to host images?

Nope!

@brainwane
Copy link
Contributor

I'd love to get this merged.

@ei8fdb do you have links for any of the user experience trainings that we did in late 2020 and early 2021? I would very much like to include those here. I'm sorry I'm late in asking for them.

@nlhkabu
Copy link
Member Author

nlhkabu commented Dec 23, 2021

Closing this and making a new PR at #10745, as I accidentally made a branch instead of a fork :)

@nlhkabu nlhkabu closed this Dec 23, 2021
@nlhkabu
Copy link
Member Author

nlhkabu commented Dec 23, 2021

@pradyunsg would you be able to remove this branch for me? Thx

@pradyunsg pradyunsg deleted the add-2020-ux-docs branch December 23, 2021 17:43
@pradyunsg
Copy link
Member

Done! :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants