Drop --build-dir from the CLI #10485

pradyunsg · 2021-09-18T09:14:47Z

This was restored as a no-op for PyCharm, as a way to soften the
migration for them. It is no longer necessary, since the migration has
completed.

Closes out #9193. Not sure if we care about calling this out in our news file.

pradyunsg · 2021-09-19T13:04:25Z

src/pip/_internal/cli/base_command.py:29:1: F401 'pip._internal.utils.deprecation.deprecated' imported but unused

Heh.

pradyunsg · 2021-09-21T18:37:10Z

(awaiting a response from myself, on the CI failures)

uranusjr · 2021-09-30T07:58:58Z

This will also need to remove test_no_clean_option_blocks_cleaning_after_wheel. This test is currently marked as xfail but passing. but #10526 is removing the xfail marker for xfail_strict, but this PR will make that test fail again.

This was restored as a no-op for PyCharm, as a way to soften the migration for them. It is no longer necessary, since the migration has completed.

pradyunsg · 2021-10-04T22:23:15Z

5. It took 5 attempts.

Bumps [pip](https://github.com/pypa/pip) from 21.2.4 to 21.3. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/pip/blob/main/NEWS.rst">pip's changelog</a>.</em></p> <blockquote> <h1>21.3 (2021-10-11)</h1> <h2>Deprecations and Removals</h2> <ul> <li>Improve deprecation warning regarding the copying of source trees when installing from a local directory. (<code>[#10128](pypa/pip#10128) <https://github.com/pypa/pip/issues/10128></code>_)</li> <li>Suppress location mismatch warnings when pip is invoked from a Python source tree, so <code>ensurepip</code> does not emit warnings on CPython <code>make install</code>. (<code>[#10270](pypa/pip#10270) <https://github.com/pypa/pip/issues/10270></code>_)</li> <li>On Python 3.10 or later, the installation scheme backend has been changed to use <code>sysconfig</code>. This is to anticipate the deprecation of <code>distutils</code> in Python 3.10, and its scheduled removal in 3.12. For compatibility considerations, pip installations running on Python 3.9 or lower will continue to use <code>distutils</code>. (<code>[#10358](pypa/pip#10358) <https://github.com/pypa/pip/issues/10358></code>_)</li> <li>Remove the <code>--build-dir</code> option and aliases, one last time. (<code>[#10485](pypa/pip#10485) <https://github.com/pypa/pip/issues/10485></code>_)</li> <li>In-tree builds are now the default. <code>--use-feature=in-tree-build</code> is now ignored. <code>--use-deprecated=out-of-tree-build</code> may be used temporarily to ease the transition. (<code>[#10495](pypa/pip#10495) <https://github.com/pypa/pip/issues/10495></code>_)</li> <li>Un-deprecate source distribution re-installation behaviour. (<code>[#8711](pypa/pip#8711) <https://github.com/pypa/pip/issues/8711></code>_)</li> </ul> <h2>Features</h2> <ul> <li>Replace vendored appdirs with platformdirs. (<code>[#10202](pypa/pip#10202) <https://github.com/pypa/pip/issues/10202></code>_)</li> <li>Support <code>PEP 610 <https://www.python.org/dev/peps/pep-0610/></code>_ to detect editable installs in <code>pip freeze</code> and <code>pip list</code>. The <code>pip list</code> column output has a new <code>Editable project location</code> column, and the JSON output has a new <code>editable_project_location</code> field. (<code>[#10249](pypa/pip#10249) <https://github.com/pypa/pip/issues/10249></code>_)</li> <li><code>pip freeze</code> will now always fallback to reporting the editable project location when it encounters a VCS error while analyzing an editable requirement. Before, it sometimes reported the requirement as non-editable. (<code>[#10410](pypa/pip#10410) <https://github.com/pypa/pip/issues/10410></code>_)</li> <li><code>pip show</code> now sorts <code>Requires</code> and <code>Required-By</code> alphabetically. (<code>[#10422](pypa/pip#10422) <https://github.com/pypa/pip/issues/10422></code>_)</li> <li>Do not raise error when there are no files to remove with <code>pip cache purge/remove</code>. Instead log a warning and continue (to log that we removed 0 files). (<code>[#10459](pypa/pip#10459) <https://github.com/pypa/pip/issues/10459></code>_)</li> <li>When backtracking during dependency resolution, prefer the dependencies which are involved in the most recent conflict. This can significantly reduce the amount of backtracking required. (<code>[#10479](pypa/pip#10479) <https://github.com/pypa/pip/issues/10479></code>_)</li> <li>Cache requirement objects, to improve performance reducing reparses of requirement strings. (<code>[#10550](pypa/pip#10550) <https://github.com/pypa/pip/issues/10550></code>_)</li> <li>Support editable installs for projects that have a <code>pyproject.toml</code> and use a build backend that supports :pep:<code>660</code>. (<code>[#8212](pypa/pip#8212) <https://github.com/pypa/pip/issues/8212></code>_)</li> <li>When a revision is specified in a Git URL, use git's partial clone feature to speed up source retrieval. (<code>[#9086](pypa/pip#9086) <https://github.com/pypa/pip/issues/9086></code>_)</li> <li>Add a <code>--debug</code> flag, to enable a mode that doesn't log errors and propagates them to the top level instead. This is primarily to aid with debugging pip's crashes. (<code>[#9349](pypa/pip#9349) <https://github.com/pypa/pip/issues/9349></code>_)</li> <li>If a host is explicitly specified as trusted by the user (via the --trusted-host option), cache HTTP responses from it in addition to HTTPS ones. (<code>[#9498](pypa/pip#9498) <https://github.com/pypa/pip/issues/9498></code>_)</li> </ul> <h2>Bug Fixes</h2> <ul> <li>Present a better error message, when a <code>file:</code> URL is not found. (<code>[#10263](pypa/pip#10263) <https://github.com/pypa/pip/issues/10263></code>_)</li> <li>Fix the auth credential cache to allow for the case in which the index url contains the username, but the password comes from an external source, such as keyring. (<code>[#10269](pypa/pip#10269) <https://github.com/pypa/pip/issues/10269></code>_)</li> <li>Fix double unescape of HTML <code>data-requires-python</code> and <code>data-yanked</code> attributes. (<code>[#10378](pypa/pip#10378) <https://github.com/pypa/pip/issues/10378></code>_)</li> <li>New resolver: Fixes depth ordering of packages during resolution, e.g. a dependency 2 levels deep will be ordered before a dependecy 3 levels deep. (<code>[#10482](pypa/pip#10482) <https://github.com/pypa/pip/issues/10482></code>_)</li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/pip/commit/abec8a701bfa66aa15fedf4c898011aa2d95f29e"><code>abec8a7</code></a> Bump for release</li> <li><a href="https://github.com/pypa/pip/commit/68a70486c9224f9d25be3cbf56c73d8a33c6a713"><code>68a7048</code></a> Update AUTHORS.txt</li> <li><a href="https://github.com/pypa/pip/commit/9f18a403ca41f4e42fbb89d286b6571a099cb54b"><code>9f18a40</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/10481">#10481</a> from notatallshaw/prefer_failures</li> <li><a href="https://github.com/pypa/pip/commit/db496cbce518fa159476695db0cd4f1c1a8ab6f5"><code>db496cb</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/10563">#10563</a> from pradyunsg/shorter-timeout</li> <li><a href="https://github.com/pypa/pip/commit/4fac2b90a5d200b46e7b576013bb25f4ebb3f937"><code>4fac2b9</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/10550">#10550</a> from jbylund/joe/cache_requirement_creation</li> <li><a href="https://github.com/pypa/pip/commit/786957cf85a641d49b4cfcceef717ef229ac8238"><code>786957c</code></a> Use a shorter timeout, to ensure that this fails more often</li> <li><a href="https://github.com/pypa/pip/commit/1e3c127d4a938643aca1bbc25e6581493e316476"><code>1e3c127</code></a> Avoid passing <code>.</code> to vendoring</li> <li><a href="https://github.com/pypa/pip/commit/610424f9f8ad1f99d0a48bf9a53e7a9df4242304"><code>610424f</code></a> Quote "PreferenceInformation" to avoid runtime NameError</li> <li><a href="https://github.com/pypa/pip/commit/c01b5c6d8a4858cf733408b4b020933f902dda9e"><code>c01b5c6</code></a> Update a test for resolvelib 0.8.0</li> <li><a href="https://github.com/pypa/pip/commit/394a24eb1a5f9af5da7d4d2452ed5fe952de5db2"><code>394a24e</code></a> Upgrade resolvelib to 0.8.0</li> <li>Additional commits viewable in <a href="https://github.com/pypa/pip/compare/21.2.4...21.3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pip&package-manager=pip&previous-version=21.2.4&new-version=21.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

As of 21.3 pip: > Remove the --build-dir option and aliases, one last time. (pypa/pip#10485) https://pip.pypa.io/en/stable/news/#v21-3 Previous versions warn about deprecation. The builddir is provided to pip via env variable PIP_BUILD in Tox task. The purpose of changing of default builddir was noexec mount option for /tmp in Travis (see 17d571c). Since Travis is no longer used and Azure lacks this issue the PIP_BUILD can be safely removed. Note: pip 21.3 just ignores this env variable, which is more than can be said for the command line option. It's better to clean it up, since the behaviour may be changed in future. Fixes: https://pagure.io/freeipa/issue/9011 Signed-off-by: Stanislav Levin <[email protected]>

As of 21.3 pip: > Remove the --build-dir option and aliases, one last time. (pypa/pip#10485) https://pip.pypa.io/en/stable/news/#v21-3 Previous versions warn about deprecation. The builddir is provided to pip via env variable PIP_BUILD in Tox task. The purpose of changing of default builddir was noexec mount option for /tmp in Travis (see 17d571c). Since Travis is no longer used and Azure lacks this issue the PIP_BUILD can be safely removed. Note: pip 21.3 just ignores this env variable, which is more than can be said for the command line option. It's better to clean it up, since the behaviour may be changed in future. This is effectively the revert of 17d571c. Fixes: https://pagure.io/freeipa/issue/9011 Signed-off-by: Stanislav Levin <[email protected]>

As of 21.3 pip: > Remove the --build-dir option and aliases, one last time. (pypa/pip#10485) https://pip.pypa.io/en/stable/news/#v21-3 Previous versions warn about deprecation. The builddir is provided to pip via env variable PIP_BUILD in Tox task. The purpose of changing of default builddir was noexec mount option for /tmp in Travis (see 17d571c). Since Travis is no longer used and Azure lacks this issue the PIP_BUILD can be safely removed. Note: pip 21.3 just ignores this env variable, which is more than can be said for the command line option. It's better to clean it up, since the behaviour may be changed in future. This is effectively the revert of 17d571c. Fixes: https://pagure.io/freeipa/issue/9011 Signed-off-by: Stanislav Levin <[email protected]> Reviewed-By: Rob Crittenden <[email protected]>

As of 21.3 pip: > Remove the --build-dir option and aliases, one last time. (pypa/pip#10485) https://pip.pypa.io/en/stable/news/#v21-3 Previous versions warn about deprecation. The builddir is provided to pip via env variable PIP_BUILD in Tox task. The purpose of changing of default builddir was noexec mount option for /tmp in Travis (see 17d571c). Since Travis is no longer used and Azure lacks this issue the PIP_BUILD can be safely removed. Note: pip 21.3 just ignores this env variable, which is more than can be said for the command line option. It's better to clean it up, since the behaviour may be changed in future. This is effectively the revert of 17d571c. Fixes: https://pagure.io/freeipa/issue/9011 Signed-off-by: Stanislav Levin <[email protected]>

pradyunsg added this to the 21.3 milestone Sep 18, 2021

pradyunsg added the S: awaiting response Waiting for a response/more information label Sep 21, 2021

pradyunsg removed the S: awaiting response Waiting for a response/more information label Sep 22, 2021

uranusjr mentioned this pull request Sep 30, 2021

Force strict xfail on pytest, and update/remove tests accordingly #10526

Merged

pradyunsg force-pushed the drop-build-dir branch from d1b02e1 to fd9b14b Compare October 3, 2021 13:34

pradyunsg added the !release blocker Hold a release until this is resolved label Oct 3, 2021

pradyunsg force-pushed the drop-build-dir branch from fd9b14b to 1b5c076 Compare October 3, 2021 15:55

Drop --build-dir from the CLI

bc98892

This was restored as a no-op for PyCharm, as a way to soften the migration for them. It is no longer necessary, since the migration has completed.

pradyunsg force-pushed the drop-build-dir branch from 1b5c076 to bc98892 Compare October 4, 2021 21:46

📰

62ead58

pradyunsg force-pushed the drop-build-dir branch from 8825815 to 62ead58 Compare October 4, 2021 22:21

sbidoul approved these changes Oct 5, 2021

View reviewed changes

uranusjr approved these changes Oct 5, 2021

View reviewed changes

uranusjr merged commit 3bbf6e9 into pypa:main Oct 5, 2021

pradyunsg deleted the drop-build-dir branch October 5, 2021 08:04

pradyunsg mentioned this pull request Oct 6, 2021

Temporarily restore --build-dir for PyCharm #9193

Closed

pradyunsg mentioned this pull request Oct 12, 2021

21.3 pip3 (arm64) failing when used with "-b" option #10576

Closed

1 task

stanislavlevin mentioned this pull request Oct 19, 2021

[self testsuite] testpep561.py::PEP561Suite tests fail against pip 21.3 python/mypy#11355

Closed

stanislavlevin mentioned this pull request Oct 19, 2021

azure: Don't customize pip's builddir freeipa/freeipa#6053

Closed

github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop --build-dir from the CLI #10485

Drop --build-dir from the CLI #10485

pradyunsg commented Sep 18, 2021

pradyunsg commented Sep 19, 2021

pradyunsg commented Sep 21, 2021

uranusjr commented Sep 30, 2021

pradyunsg commented Oct 4, 2021 •

edited

Loading

Drop --build-dir from the CLI #10485

Drop --build-dir from the CLI #10485

Conversation

pradyunsg commented Sep 18, 2021

pradyunsg commented Sep 19, 2021

pradyunsg commented Sep 21, 2021

uranusjr commented Sep 30, 2021

pradyunsg commented Oct 4, 2021 • edited Loading

pradyunsg commented Oct 4, 2021 •

edited

Loading