Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pre-release to satisfy build requirements #11124

Merged
merged 1 commit into from
May 16, 2022

Conversation

uranusjr
Copy link
Member

This bug has been there fore since forever, but only exposed when we actually trying to enforce it to manually populated environments.

Fix #11123.

@uranusjr uranusjr added the C: PEP 517 impact Affected by PEP 517 processing label May 16, 2022
Copy link
Contributor

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big +1 on that one. Thanks @uranusjr for looking at it!

@pradyunsg pradyunsg merged commit f20ab57 into pypa:main May 16, 2022
@uranusjr uranusjr deleted the use-contain-for-checking branch May 16, 2022 14:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: PEP 517 impact Affected by PEP 517 processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression: --no-build-isolation validation causes failure with setup deps installed from custom commit
3 participants