Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of distutils.utils.change_root with copied-over logic #11194

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Replace usage of distutils.utils.change_root with copied-over logic #11194

merged 1 commit into from
Jun 17, 2022

Conversation

pradyunsg
Copy link
Member

This eliminates an import from distutils, by pulling in the relevant code
into pip itself.

Related to #11103

@pradyunsg
Replace usage of distutils.utils.change_root with copied-over logic
c520ccf 
This eliminates an import from distutils, by pulling in the relevant code
into pip itself.
@pradyunsg pradyunsg added type: deprecation Related to deprecation / removal. skip news Does not need a NEWS file entry (eg: trivial changes) labels Jun 17, 2022
pfmoore
pfmoore approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to CI passing, of course...

@pradyunsg
Copy link
Member Author

Thanks for the quick review @pfmoore! ^>^

@pradyunsg pradyunsg merged commit ae324d1 into pypa:main Jun 17, 2022
@uranusjr
Copy link
Member

uranusjr commented Jun 21, 2022 •
edited
Loading

I forgot what root is even for in get_scheme, but change_root is known to be problematic in the first place, so one of those days we should deprecate and remove whatever is using it (or re-define it to something that is not problematic).

@pradyunsg pradyunsg deleted the distutils-change-root branch June 21, 2022 16:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pfmoore pfmoore pfmoore approved these changes

Assignees
No one assigned
Labels
skip news Does not need a NEWS file entry (eg: trivial changes) type: deprecation Related to deprecation / removal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pradyunsg @uranusjr @pfmoore