Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a --python option #11320
Add a --python option #11320
Changes from 1 commit
79cd599
95cf55b
42eae50
78e7ea8
24c22a3
01e122e
b1eb912
f86a140
b5afdd6
61249ed
d0b5a8f
b6be01a
ddfa05c
3333891
4dc35b7
0d6fada
ebe491a
b8aa21b
9b638ec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could do this without too much fuss with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the
shutil.which
docs,That could give weird false positives (for example, we have a
python.exe
in the CWD, and we do--python=.venv/python.exe
).On reflection, I think this is too much effort, and we should just expect the user to supply the
.exe
(i.e., provide the name of a file that exists). I suspect most people will use autocomplete anyway, if they are entering the path by hand.