Add a version check to __pip-runner__.py #11342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
reviewed
Aug 3, 2022
pradyunsg
approved these changes
Aug 3, 2022
pfmoore
force-pushed
the
runner_version_check
branch
from
c6b4f48 to
c69ea02
Compare
sbidoul
approved these changes
Aug 4, 2022
|
Given that I have two approvals, and I've withdrawn my objections to maintaining the code as Python 2 compatible, I'll assume this is OK and merge it at the weekend when I merge the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check to the "pip runner" script to ensure that it is being run by a supported version of Python. This is not needed for the "isolated build" use case, as we always know which Python version is running the script in that case. But now that the script is also being used for the
--pythonoption, this makes the error handling a bit more robust if an unsupported python version is supplied.Note that in order to avoid an ugly backtrace, this change now requires
__pip-runner__.pyto conform to Python 2 compatible syntax (although Python 3 features may be used once the version check is complete).I'm not sure if it's worth adding tests (we don't currently have tests that explicitly target this file).