Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows appdirs tests #3275

Merged
merged 6 commits into from
Dec 1, 2015

Conversation

xavfernandez
Copy link
Member

Review on Reviewable

@xavfernandez xavfernandez force-pushed the fix_windows_appdirs_tests branch from 2467238 to 2184d03 Compare November 30, 2015 21:51
@xavfernandez
Copy link
Member Author

@pfmoore First commit gave lots of assert '/home/test/Library/Caches\\pip' == '/home/test/Library/Caches/pip'
cf https://ci.appveyor.com/project/xavfernandez/pip/build/1.0.7/job/4vhtq5lp0137eipy

My os.path monkeypatch seems to work but maybe it would be cleaner to simply @pytest.mark.skipif("sys.platform == 'win32'") ?

appdirs_tests seems to be fixed in https://ci.appveyor.com/project/xavfernandez/pip/build/1.0.10/job/w9s58d0nqnjspu1r

@pfmoore
Copy link
Member

pfmoore commented Dec 1, 2015

@xavfernandez Thanks for doing this!

I prefer not skipping tests on Windows, because that means Windows users can't confirm they didn't break Unix functionality (the same applies the other way round - I like having Windows tests that work on Unix as well, so monkeypatching ntpath in to test the Windows code path is good).

@xavfernandez xavfernandez force-pushed the fix_windows_appdirs_tests branch from b549718 to b939c3d Compare December 1, 2015 11:57
@xavfernandez
Copy link
Member Author

Merging this. There are still 9 unit tests failing, cf https://ci.appveyor.com/project/xavfernandez/pip/build/1.0.13/job/3365jywp02iuanh9

xavfernandez added a commit that referenced this pull request Dec 1, 2015
@xavfernandez xavfernandez merged commit b4f6766 into pypa:develop Dec 1, 2015
@xavfernandez xavfernandez deleted the fix_windows_appdirs_tests branch December 2, 2015 13:48
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants