-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows appdirs tests #3275
Fix windows appdirs tests #3275
Conversation
xavfernandez
commented
Nov 30, 2015
2467238
to
2184d03
Compare
@pfmoore First commit gave lots of My os.path monkeypatch seems to work but maybe it would be cleaner to simply appdirs_tests seems to be fixed in https://ci.appveyor.com/project/xavfernandez/pip/build/1.0.10/job/w9s58d0nqnjspu1r |
@xavfernandez Thanks for doing this! I prefer not skipping tests on Windows, because that means Windows users can't confirm they didn't break Unix functionality (the same applies the other way round - I like having Windows tests that work on Unix as well, so monkeypatching |
b549718
to
b939c3d
Compare
Merging this. There are still 9 unit tests failing, cf https://ci.appveyor.com/project/xavfernandez/pip/build/1.0.13/job/3365jywp02iuanh9 |
Fix some unit tests on windows