Fix pip install --target #4111

halms · 2016-11-13T17:09:41Z

As I messed up my branch, github force closed my last PR.
So this is a new, clean version of PR #4103 .

Sorry for the mess.

For reference: the original description of PR #4103:

Currently pip install --target does fail when a prefix is set (e.g. in a .pydistutils.cfg).
This is especially the case on macOS when Python is installed via Homebrew.
It used to fail in the same way when using the --user flag. This was initially fixed in b227c45

Now I just replicated this fix for the usage of --target.

Interestingly, --target used to work when supplying --install-option="--prefix=" at the command line as advised in Homebrew-and-Python.md, but now doesn't anymore.
The error message changes though whether --install-option="--prefix=" is set or not. - When the option is set, pip fails when get_lib_location_guesses calls distutils_scheme, so it seems the --install-prefix switch is ignored there.

Anyway, this pull request should fix it all by enforcing prefix to be empty when --target is used.
Although this works fine for me, I am not yet sure if these changes would break anything else.

This change is

techtonik · 2016-11-21T14:44:31Z

This needs a rebase.

techtonik · 2016-11-21T14:46:21Z

pip/commands/install.py

@@ -266,6 +276,7 @@ def run(self, options, args):
                    "continue."
                )
            install_options.append('--home=' + temp_target_dir)
+            install_options.append('--prefix=')


Why add --prefix here?

I added the same thing as already exists for the --user command (line 260).
An empty prefix is set in order to overwrite one set as a default somewhere else (e.g. as it is the case with homebrew python).

This branch should be dead because of exception above. Filled #4132

Ok. Tests are failing. Looks like this piece of code is still needed.

To my understanding the exception only avoids both options being set at the pip command line.
This line ensures that a prefix set somwhere else is effectively overriden as it does basically the same as the workaround there:
https://github.com/Homebrew/brew/blob/master/docs/Homebrew-and-Python.md#note-on-pip-install---user

I do not fully understand, how install_options and distutils_scheme() in locations.py do work together, but it seems to work this way.

halms · 2016-11-21T20:31:00Z

I just wanted to add a follow-up to the discussion that started in #4103 .

Regarding mutual exclusivity of the options:
https://docs.python.org/3/install/index.html#alternate-installation states that for setup.py --user, --home, and --prefix are mutually exclusive. As --target uses --home, that makes the combination in question mutually exclusive as well.

I would also suggest that we can assume that if one of the flags is given on the command line (or in a requirements.txt), that any default configuration can be overridden quietly.

mgwio · 2016-12-11T20:43:33Z

I'm interested in this change. Will we see it go forward any time soon?

halms · 2016-12-20T10:02:35Z

Is there anyone we should ping to review the code or something?
I'm not yet familiar with the responsibilities around here.

mijohansen · 2017-01-31T21:46:31Z

After some plundering I just commented out the check that raises the error in /usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/command/install.py:262

As I am new to Python/PiP and just want to continue testing this really dirty hack saved the day.

silverwind · 2017-02-17T10:38:52Z

Looking forward to this fix landing. pip install -t localdir is broken on Homebrew, and the only workaround that is working (echo -e '[install]\nprefix=' > ~/.pydistutils.cfg) must be removed afterwards as it breaks global package installs.

BrownTruck · 2017-04-01T17:05:12Z

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

Also override defaults set somewhere (e.g. .pydistutils.cfg) when command line switches are given.

Replace ``--no-use-wheel`` with ``--no-binary=:all:``

Replace --no-use-wheel with --no-binary=:all: and remove assertion of deprecation message.

BrownTruck · 2017-06-02T09:30:15Z

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

techtonik · 2017-06-11T09:40:15Z

For those who want to see this fixed, here is the way:

read the proposed fix
make sure you understand what it does
make sure to ask questions and research if you don't understand
write a report to prove to maintainers that it solves the problem
get link to your report here

Even partial reports can help.

flebel · 2017-06-16T00:11:22Z

This workaround fixed it for me:
PYTHONPATH=$PREFIX_PATH/lib/python2.7/site-package pip install --install-option="--prefix=$PREFIX_PATH" -r requirements.txt

https://stackoverflow.com/a/2916320

techtonik · 2017-06-17T15:26:40Z

@halmi try to resolve conflict. It is just a few lines fix.

halms · 2017-10-10T11:26:34Z

This is now handled in #4557.

lock · 2019-06-02T17:06:23Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

techtonik reviewed Nov 21, 2016

View reviewed changes

jaraco mentioned this pull request Mar 28, 2017

Fails on homebrew Python jaraco/pip-run#14

Closed

BrownTruck added the needs rebase or merge PR has conflicts with current master label Apr 1, 2017

Make --target, --user, and --prefix mutually exclusive.

5268635

Also override defaults set somewhere (e.g. .pydistutils.cfg) when command line switches are given.

BrownTruck removed the needs rebase or merge PR has conflicts with current master label Apr 1, 2017

Add news entry.

2174f50

halms mentioned this pull request Apr 1, 2017

The --target option clashes with other command line flags and config files #4390

Closed

vitorgalvao mentioned this pull request Apr 2, 2017

Auto update keeps running in background. deanishe/alfred-workflow#111

Closed

halmi added 3 commits April 3, 2017 13:11

Fix CI test errors.

27d1732

Replace ``--no-use-wheel`` with ``--no-binary=:all:``

Fix more unit tests

90e8887

Replace --no-use-wheel with --no-binary=:all: and remove assertion of deprecation message.

Fix too long line.

fe7318c

BrownTruck added the needs rebase or merge PR has conflicts with current master label Jun 2, 2017

techtonik mentioned this pull request Jun 17, 2017

Mutually exclusive --target, --user and --prefix #4557

Closed

pradyunsg added S: awaiting response Waiting for a response/more information type: enhancement Improvements to functionality labels Aug 21, 2017

halms closed this Oct 10, 2017

pradyunsg removed the S: awaiting response Waiting for a response/more information label Oct 10, 2017

lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019

lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019

pradyunsg removed the needs rebase or merge PR has conflicts with current master label Apr 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix pip install --target #4111

Fix pip install --target #4111

halms commented Nov 13, 2016 •

edited by dstufft

Loading

techtonik commented Nov 21, 2016

techtonik Nov 21, 2016

halms Nov 21, 2016 •

edited

Loading

techtonik Nov 22, 2016

techtonik Nov 22, 2016

halms Nov 22, 2016 •

edited

Loading

halms Nov 22, 2016

halms commented Nov 21, 2016

mgwio commented Dec 11, 2016

halms commented Dec 20, 2016

mijohansen commented Jan 31, 2017

silverwind commented Feb 17, 2017

BrownTruck commented Apr 1, 2017

BrownTruck commented Jun 2, 2017

techtonik commented Jun 11, 2017

flebel commented Jun 16, 2017

techtonik commented Jun 17, 2017

halms commented Oct 10, 2017

lock bot commented Jun 2, 2019

Fix pip install --target #4111

Fix pip install --target #4111

Conversation

halms commented Nov 13, 2016 • edited by dstufft Loading

techtonik commented Nov 21, 2016

techtonik Nov 21, 2016

Choose a reason for hiding this comment

halms Nov 21, 2016 • edited Loading

Choose a reason for hiding this comment

techtonik Nov 22, 2016

Choose a reason for hiding this comment

techtonik Nov 22, 2016

Choose a reason for hiding this comment

halms Nov 22, 2016 • edited Loading

Choose a reason for hiding this comment

halms Nov 22, 2016

Choose a reason for hiding this comment

halms commented Nov 21, 2016

mgwio commented Dec 11, 2016

halms commented Dec 20, 2016

mijohansen commented Jan 31, 2017

silverwind commented Feb 17, 2017

BrownTruck commented Apr 1, 2017

BrownTruck commented Jun 2, 2017

techtonik commented Jun 11, 2017

flebel commented Jun 16, 2017

techtonik commented Jun 17, 2017

halms commented Oct 10, 2017

lock bot commented Jun 2, 2019

halms commented Nov 13, 2016 •

edited by dstufft

Loading

halms Nov 21, 2016 •

edited

Loading

halms Nov 22, 2016 •

edited

Loading