Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-released package upgrade hints #5408

Closed
wants to merge 1 commit into from
Closed

Add pre-released package upgrade hints #5408

wants to merge 1 commit into from

Conversation

demophoon
Copy link

@demophoon demophoon commented May 15, 2018 •
edited
Loading

Before this commit when querying for an installed package using pip if
the package that was returned contained a pre-released version of the
package it was not intuitive that the pre-released version of the
package could not be directly upgraded to without the --pre flag.

This commit shows additional information on how to upgrade to
pre-released versions of a package if one is found in the search.

Fixes #5169.

@demophoon demophoon force-pushed the enhancement/master/5169-pre-release-hinting branch 2 times, most recently from 9037df1 to 1a300bc Compare May 15, 2018 14:29
@demophoon demophoon changed the title (WIP) Add pre-released package upgrade hints Add pre-released package upgrade hints May 15, 2018
@demophoon demophoon force-pushed the enhancement/master/5169-pre-release-hinting branch from 1a300bc to 83f0db9 Compare May 15, 2018 18:41
@pradyunsg pradyunsg added the S: needs triage Issues/PRs that need to be triaged label May 16, 2018
@pradyunsg
Copy link
Member

Hey @demophoon! Thanks for this PR! :)

Instead of a "trivial" NEWS fragment, this should have a "feature" NEWS fragment.

pradyunsg
pradyunsg reviewed Jun 5, 2018
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs tests -- you'd want to add a test to tests/functional/test_search.py for checking that pip search ... shows the installation suggestion when the latest version is a pre-release.

@pradyunsg pradyunsg added this to the 18.0 milestone Jun 5, 2018
@pradyunsg pradyunsg added type: enhancement Improvements to functionality and removed S: needs triage Issues/PRs that need to be triaged labels Jun 5, 2018
@demophoon
Copy link
Author

I will add those tests when I get a free moment! Thanks for giving this a look over!

@pradyunsg
Copy link
Member

Pushing this down the road to the next release since I don't think this'd happen in time for 18.0.

@pradyunsg pradyunsg modified the milestones: 18.0, 18.1 Jul 9, 2018
@pradyunsg
Copy link
Member

@demophoon pip 18.1 is scheduled for next month; would you be able to take a look at this PR before then?

Otherwise, we can go ahead and defer this to a later release.

@demophoon
Copy link
Author

I scheduled some time this weekend to finish this up! Sorry it has taken so long!

@demophoon demophoon force-pushed the enhancement/master/5169-pre-release-hinting branch 7 times, most recently from 3997f5d to ce65271 Compare September 25, 2018 01:01
@demophoon
Add hint when displaying pre-released package if an update exists
b67a7c9 
Before this commit when querying for an installed package using pip if
the package that was returned contained a pre-released version of the
package it was not intuitive that the pre-released version of the
package could not be directly upgraded to without the `--pre` flag.

This commit shows additional information on how to upgrade to
pre-released versions of a package if one is found in the search.

Fixes pypa#5169.
@demophoon demophoon force-pushed the enhancement/master/5169-pre-release-hinting branch from ce65271 to b67a7c9 Compare September 25, 2018 01:12
@pradyunsg
Copy link
Member

I missed that you'd pushed changes to this PR.

The CI seems to be failing since the tests corresponding to this functionality are failing.

Deferring this to a later release since this isn't in a merge-able state right now.

@pradyunsg pradyunsg removed this from the 18.1 milestone Sep 30, 2018
@lkollar lkollar mentioned this pull request Oct 26, 2018
Merged
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg left review comments

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation type: enhancement Improvements to functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display pre-release version hint in package version output of "pip search" (and others)
2 participants
@demophoon @pradyunsg