Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-3942: keyboard interrupts & stdout #6485

Closed
wants to merge 3 commits into from

Conversation

DavidBord
Copy link
Contributor

Since initial imports are pretty slow a keyboard interrupt generates a pretty nasty traceback to stdout so suppress them until the logger that deals with it is initialized

Fixes #3942

David Bordeynik added 3 commits May 9, 2019 16:47
…generates a pretty nasty traceback to stdout so suppress them until the logger that deals with it is initialized
@cjerdonek
Copy link
Member

I’m not sure we want to be suppressing the default signal handler as tracebacks are useful for understanding e.g. where pip got stuck. Also, the original issue was about auto-completion and suggested a narrower fix.

@pfmoore
Copy link
Member

pfmoore commented May 9, 2019

Agreed, I think this is too broad a change to be appropriate as a fix for #3942, which is a very specific problem.

@auvipy
Copy link

auvipy commented May 9, 2019

How can I cancel my review?

@pradyunsg
Copy link
Member

pradyunsg commented Jun 12, 2019

We spent a while discussing this at PyCon (me and @DavidBord). I think we should take a step back and the fix for this would probably be just to suppress stderr when pip's being used for autocompletion -- this would be a change in our completion scripts defined in autocompletion.py.

@pradyunsg pradyunsg closed this Jun 12, 2019
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jul 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip autocompletion should silence of KeyboardInterrupts
5 participants